chrome/browser/download/download_ui_controller.cc - Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller.cc

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_ui_controller.h ('k') | chrome/browser/download/download_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller.cc

diff --git a/chrome/browser/download/download_ui_controller.cc b/chrome/browser/download/download_ui_controller.cc

index 992525a3d0da39705fda53f4cf8f4f3cecdc23d7..6f8b2199d26197b06f542f3e883d4c7859914d12 100644

--- a/chrome/browser/download/download_ui_controller.cc

+++ b/chrome/browser/download/download_ui_controller.cc

@@ -57,11 +57,11 @@ class DefaultUIControllerDelegate : public DownloadUIController::Delegate {

// |profile| is required to outlive DefaultUIControllerDelegate.

explicit DefaultUIControllerDelegate(Profile* profile)

: profile_(profile) {}

- virtual ~DefaultUIControllerDelegate() {}

+ ~DefaultUIControllerDelegate() override {}

private:

// DownloadUIController::Delegate

- virtual void OnNewDownloadReady(content::DownloadItem* item) override;

+ void OnNewDownloadReady(content::DownloadItem* item) override;

Profile* profile_;

};

« no previous file with comments | « chrome/browser/download/download_ui_controller.h ('k') | chrome/browser/download/download_ui_controller_unittest.cc » ('j') | no next file with comments »