chrome/browser/download/download_status_updater_mac.mm - Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_status_updater_mac.mm

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_status_updater.h ('k') | chrome/browser/download/download_status_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_status_updater_mac.mm

diff --git a/chrome/browser/download/download_status_updater_mac.mm b/chrome/browser/download/download_status_updater_mac.mm

index cbed5cd37ed539b44e7bd1871b0112d7224bf1a5..2cdb9523ab840055ec560c3b7def6cbe99e8b5b0 100644

--- a/chrome/browser/download/download_status_updater_mac.mm

+++ b/chrome/browser/download/download_status_updater_mac.mm

@@ -101,9 +101,7 @@ class CrNSProgressUserData : public base::SupportsUserData::Data {

: target_(target) {

progress_.reset(progress);

}

- virtual ~CrNSProgressUserData() {

- [progress_.get() unpublish];

- }

+ ~CrNSProgressUserData() override { [progress_.get() unpublish]; }

NSProgress* progress() const { return progress_.get(); }

base::FilePath target() const { return target_; }

« no previous file with comments | « chrome/browser/download/download_status_updater.h ('k') | chrome/browser/download/download_status_updater_unittest.cc » ('j') | no next file with comments »