Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3936)

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_request_limiter.h
diff --git a/chrome/browser/download/download_request_limiter.h b/chrome/browser/download/download_request_limiter.h
index 7627e282f782e4274d345dbe7ded0e17cda23e0c..6d54c7ae88a8f06d6ac81323cd3a6458a5925297 100644
--- a/chrome/browser/download/download_request_limiter.h
+++ b/chrome/browser/download/download_request_limiter.h
@@ -83,7 +83,7 @@ class DownloadRequestLimiter
TabDownloadState(DownloadRequestLimiter* host,
content::WebContents* web_contents,
content::WebContents* originating_web_contents);
- virtual ~TabDownloadState();
+ ~TabDownloadState() override;
// Status of the download.
void set_download_status(DownloadRequestLimiter::DownloadStatus status) {
@@ -102,12 +102,12 @@ class DownloadRequestLimiter
}
// content::WebContentsObserver overrides.
- virtual void AboutToNavigateRenderView(
+ void AboutToNavigateRenderView(
content::RenderViewHost* render_view_host) override;
// Invoked when a user gesture occurs (mouse click, enter or space). This
// may result in invoking Remove on DownloadRequestLimiter.
- virtual void DidGetUserGesture() override;
- virtual void WebContentsDestroyed() override;
+ void DidGetUserGesture() override;
+ void WebContentsDestroyed() override;
// Asks the user if they really want to allow the download.
// See description above CanDownloadOnIOThread for details on lifetime of
@@ -132,9 +132,9 @@ class DownloadRequestLimiter
bool is_showing_prompt() const;
// content::NotificationObserver method.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Remember to either block or allow automatic downloads from this origin.
void SetContentSetting(ContentSetting setting);

Powered by Google App Engine
This is Rietveld 408576698