Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_ui_controller_unittest.cc
diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc
index d540ca8da6b26ffebee121054b9a596a4630ffc9..c909e88c8c171a17c1e033effc12d8ef59e14de4 100644
--- a/chrome/browser/download/download_ui_controller_unittest.cc
+++ b/chrome/browser/download/download_ui_controller_unittest.cc
@@ -37,10 +37,10 @@ namespace {
class TestDelegate : public DownloadUIController::Delegate {
public:
explicit TestDelegate(base::WeakPtr<content::DownloadItem*> receiver);
- virtual ~TestDelegate() {}
+ ~TestDelegate() override {}
private:
- virtual void OnNewDownloadReady(content::DownloadItem* item) override;
+ void OnNewDownloadReady(content::DownloadItem* item) override;
base::WeakPtr<content::DownloadItem*> receiver_;
};
@@ -58,12 +58,12 @@ void TestDelegate::OnNewDownloadReady(content::DownloadItem* item) {
class TestDownloadService : public DownloadService {
public:
explicit TestDownloadService(Profile* profile);
- virtual ~TestDownloadService();
+ ~TestDownloadService() override;
void set_download_history(scoped_ptr<DownloadHistory> download_history) {
download_history_.swap(download_history);
}
- virtual DownloadHistory* GetDownloadHistory() override;
+ DownloadHistory* GetDownloadHistory() override;
private:
scoped_ptr<DownloadHistory> download_history_;
@@ -127,7 +127,7 @@ class DownloadUIControllerTest : public ChromeRenderViewHostTestHarness {
HistoryService::DownloadQueryCallback download_query_callback_;
private:
- virtual void QueryDownloads(
+ void QueryDownloads(
const HistoryService::DownloadQueryCallback& callback) override {
download_query_callback_ = callback;
}
« no previous file with comments | « chrome/browser/download/download_ui_controller.cc ('k') | chrome/browser/download/save_package_file_picker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698