chrome/browser/download/download_ui_controller.h - Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller.h

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_test_file_activity_observer.cc ('k') | chrome/browser/download/download_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller.h

diff --git a/chrome/browser/download/download_ui_controller.h b/chrome/browser/download/download_ui_controller.h

index 6ac1fb5a717fc2323d8c102e22b401ab6525385f..767b87c42fa7ebc43db0e243100458194effaa62 100644

--- a/chrome/browser/download/download_ui_controller.h

+++ b/chrome/browser/download/download_ui_controller.h

@@ -36,13 +36,13 @@ class DownloadUIController : public AllDownloadItemNotifier::Observer {

DownloadUIController(content::DownloadManager* manager,

scoped_ptr<Delegate> delegate);

- virtual ~DownloadUIController();

+ ~DownloadUIController() override;

private:

- virtual void OnDownloadCreated(content::DownloadManager* manager,

- content::DownloadItem* item) override;

- virtual void OnDownloadUpdated(content::DownloadManager* manager,

- content::DownloadItem* item) override;

+ void OnDownloadCreated(content::DownloadManager* manager,

+ content::DownloadItem* item) override;

+ void OnDownloadUpdated(content::DownloadManager* manager,

+ content::DownloadItem* item) override;

AllDownloadItemNotifier download_notifier_;