Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/download/download_history_unittest.cc

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_history.cc ('k') | chrome/browser/download/download_item_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_history_unittest.cc
diff --git a/chrome/browser/download/download_history_unittest.cc b/chrome/browser/download/download_history_unittest.cc
index c761a7596e845fed97fd98970293915dc8c8d22e..608029a1e474729e699805f996a278726b343b8d 100644
--- a/chrome/browser/download/download_history_unittest.cc
+++ b/chrome/browser/download/download_history_unittest.cc
@@ -70,9 +70,9 @@ class FakeHistoryAdapter : public DownloadHistory::HistoryAdapter {
fail_create_download_(false) {
}
- virtual ~FakeHistoryAdapter() {}
+ ~FakeHistoryAdapter() override {}
- virtual void QueryDownloads(
+ void QueryDownloads(
const HistoryService::DownloadQueryCallback& callback) override {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
@@ -89,7 +89,7 @@ class FakeHistoryAdapter : public DownloadHistory::HistoryAdapter {
void set_slow_create_download(bool slow) { slow_create_download_ = slow; }
- virtual void CreateDownload(
+ void CreateDownload(
const history::DownloadRow& info,
const HistoryService::DownloadCreateCallback& callback) override {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -108,13 +108,12 @@ class FakeHistoryAdapter : public DownloadHistory::HistoryAdapter {
create_download_callback_.Reset();
}
- virtual void UpdateDownload(
- const history::DownloadRow& info) override {
+ void UpdateDownload(const history::DownloadRow& info) override {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
update_download_ = info;
}
- virtual void RemoveDownloads(const IdSet& ids) override {
+ void RemoveDownloads(const IdSet& ids) override {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
for (IdSet::const_iterator it = ids.begin();
it != ids.end(); ++it) {
« no previous file with comments | « chrome/browser/download/download_history.cc ('k') | chrome/browser/download/download_item_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698