chrome/browser/download/download_permission_request.h - Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_permission_request.h

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_path_reservation_tracker.cc ('k') | chrome/browser/download/download_request_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_permission_request.h

diff --git a/chrome/browser/download/download_permission_request.h b/chrome/browser/download/download_permission_request.h

index 806b02a5fe7cec98aba4fdf8a87aa8049334149e..b067d4dcea174242064b25437aec9ab150ae0877 100644

--- a/chrome/browser/download/download_permission_request.h

+++ b/chrome/browser/download/download_permission_request.h

@@ -18,18 +18,18 @@ class DownloadPermissionRequest : public PermissionBubbleRequest {

public:

explicit DownloadPermissionRequest(

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host);

- virtual ~DownloadPermissionRequest();

+ ~DownloadPermissionRequest() override;

// PermisisonBubbleDelegate:

- virtual int GetIconID() const override;

- virtual base::string16 GetMessageText() const override;

- virtual base::string16 GetMessageTextFragment() const override;

- virtual bool HasUserGesture() const override;

- virtual GURL GetRequestingHostname() const override;

- virtual void PermissionGranted() override;

- virtual void PermissionDenied() override;

- virtual void Cancelled() override;

- virtual void RequestFinished() override;

+ int GetIconID() const override;

+ base::string16 GetMessageText() const override;

+ base::string16 GetMessageTextFragment() const override;

+ bool HasUserGesture() const override;

+ GURL GetRequestingHostname() const override;

+ void PermissionGranted() override;

+ void PermissionDenied() override;

+ void Cancelled() override;

+ void RequestFinished() override;

private:

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;