chrome/browser/download/download_request_infobar_delegate.h - Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_infobar_delegate.h

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_permission_request.h ('k') | chrome/browser/download/download_request_infobar_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_request_infobar_delegate.h

diff --git a/chrome/browser/download/download_request_infobar_delegate.h b/chrome/browser/download/download_request_infobar_delegate.h

index 0d80c46c1c7fa4628e9fc4c247f3cd27f62b2007..9bd1ba361c6921bfd38ab882fe236558fa54a03a 100644

--- a/chrome/browser/download/download_request_infobar_delegate.h

+++ b/chrome/browser/download/download_request_infobar_delegate.h

@@ -23,7 +23,7 @@ class DownloadRequestInfoBarDelegate : public ConfirmInfoBarDelegate {

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host)>

FakeCreateCallback;

- virtual ~DownloadRequestInfoBarDelegate();

+ ~DownloadRequestInfoBarDelegate() override;

// Creates a download request delegate and adds it to |infobar_service|.

static void Create(

@@ -47,11 +47,11 @@ class DownloadRequestInfoBarDelegate : public ConfirmInfoBarDelegate {

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host);

// ConfirmInfoBarDelegate:

- virtual int GetIconID() const override;

- virtual base::string16 GetMessageText() const override;

- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;

- virtual bool Accept() override;

- virtual bool Cancel() override;

+ int GetIconID() const override;

+ base::string16 GetMessageText() const override;

+ base::string16 GetButtonLabel(InfoBarButton button) const override;

+ bool Accept() override;

+ bool Cancel() override;

bool responded_;

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;