|
Fix crash when user closes window prior to the "Confirm Install" prompt showing.
This CL moves ExtensionInstallPrompt::ShowParams to its own class. The new class
observes the content::WebContents and gfx::NativeWindow for their destruction.
If the window is closed prior to the "Confirm Install" prompt showing, the
prompt is shown as a non-modal free-standing dialog.
BUG= 422814
TEST=ExtensionInstallPromptBrowserTest.*
Committed: https://crrev.com/d53564d3743bc2da768b38f0db34090a7bb43fea
Cr-Commit-Position: refs/heads/master@{#301674}
Total comments: 5
Total comments: 1
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+572 lines, -76 lines) |
Patch |
|
M |
chrome/browser/extensions/extension_install_prompt.h
|
View
|
1
|
4 chunks |
+3 lines, -22 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_install_prompt.cc
|
View
|
1
2
3
4
5
|
6 chunks |
+11 lines, -24 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_install_prompt_browsertest.cc
|
View
|
1
|
1 chunk |
+140 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_install_prompt_show_params.h
|
View
|
1
2
3
|
1 chunk |
+64 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_install_prompt_show_params.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+100 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_install_prompt_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/external_install_error.h
|
View
|
1
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/external_install_error.cc
|
View
|
1
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/aura/native_window_tracker_aura.h
|
View
|
1
2
3
4
5
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/aura/native_window_tracker_aura.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
|
View
|
1
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
|
View
|
1
|
4 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
|
View
|
1
2
3
4
5
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h
|
View
|
1
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
|
View
|
1
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A |
chrome/browser/ui/cocoa/native_window_tracker_cocoa.h
|
View
|
1
2
3
4
5
|
1 chunk |
+27 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/cocoa/native_window_tracker_cocoa.mm
|
View
|
1
2
3
4
5
|
1 chunk |
+66 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/native_window_tracker.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+22 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/native_window_tracker_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/extensions/extension_install_dialog_view.h
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
|
View
|
1
2
3
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_extensions.gypi
|
View
|
1
2
3
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
3
4
5
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 39 (10 generated)
|