Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 683993002: Revert of Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed)

Created:
6 years, 1 month ago by pkotwicz
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator
Project:
chromium
Visibility:
Public.

Description

Revert of Fix crash when user closes window prior to the "Confirm Install" prompt showing (patchset #9 id:270001 of https://codereview.chromium.org/662073002/) Reason for revert: Broke test on the GPU waterfall http://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder%20%28dbg%29/builds/20292/steps/compile/logs/stdio Original issue's description: > Fix crash when user closes window prior to the "Confirm Install" prompt showing. > > This CL moves ExtensionInstallPrompt::ShowParams to its own class. The new class > observes the content::WebContents and gfx::NativeWindow for their destruction. > > If the window is closed prior to the "Confirm Install" prompt showing, the > prompt is shown as a non-modal free-standing dialog. > > BUG=422814 > TEST=ExtensionInstallPromptBrowserTest.* > > Committed: https://crrev.com/d53564d3743bc2da768b38f0db34090a7bb43fea > Cr-Commit-Position: refs/heads/master@{#301674} TBR=asargent@chromium.org,sky@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=422814 Committed: https://crrev.com/674e6a9f4dedcdd16530f3b5d99714a0595ab1c9 Cr-Commit-Position: refs/heads/master@{#301702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -573 lines) Patch
M chrome/browser/extensions/extension_install_prompt.h View 4 chunks +22 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 6 chunks +25 lines, -12 lines 0 comments Download
D chrome/browser/extensions/extension_install_prompt_browsertest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/extensions/extension_install_prompt_show_params.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/extensions/extension_install_prompt_show_params.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_install_error.h View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/external_install_error.cc View 3 chunks +3 lines, -5 lines 0 comments Download
D chrome/browser/ui/aura/native_window_tracker_aura.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/aura/native_window_tracker_aura.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/native_window_tracker_cocoa.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/cocoa/native_window_tracker_cocoa.mm View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/native_window_tracker.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/native_window_tracker_browsertest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Created Revert of Fix crash when user closes window prior to the "Confirm Install" prompt ...
6 years, 1 month ago (2014-10-28 20:38:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683993002/1
6 years, 1 month ago (2014-10-28 20:39:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 20:41:21 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 20:42:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/674e6a9f4dedcdd16530f3b5d99714a0595ab1c9
Cr-Commit-Position: refs/heads/master@{#301702}

Powered by Google App Engine
This is Rietveld 408576698