Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2496)

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_install_error.cc
diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc
index 2cb0d06c1522d52c0c8c0f9de6e3841283d309fe..730b475c419ea6c8e2f33d9f08380ee3f0f4186e 100644
--- a/chrome/browser/extensions/external_install_error.cc
+++ b/chrome/browser/extensions/external_install_error.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/extensions/extension_install_prompt_show_params.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/external_install_manager.h"
#include "chrome/browser/extensions/webstore_data_fetcher.h"
@@ -319,9 +320,10 @@ void ExternalInstallError::ShowDialog(Browser* browser) {
DCHECK(browser);
content::WebContents* web_contents = NULL;
web_contents = browser->tab_strip_model()->GetActiveWebContents();
- ExtensionInstallPrompt::ShowParams params(web_contents);
+ install_ui_show_params_.reset(
+ new ExtensionInstallPromptShowParams(web_contents));
ExtensionInstallPrompt::GetDefaultShowDialogCallback().Run(
- params, this, prompt_);
+ install_ui_show_params_.get(), this, prompt_);
}
const Extension* ExternalInstallError::GetExtension() const {
@@ -377,7 +379,7 @@ void ExternalInstallError::OnFetchComplete() {
}
void ExternalInstallError::OnDialogReady(
- const ExtensionInstallPrompt::ShowParams& show_params,
+ ExtensionInstallPromptShowParams* show_params,
ExtensionInstallPrompt::Delegate* prompt_delegate,
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt) {
DCHECK_EQ(this, prompt_delegate);
« no previous file with comments | « chrome/browser/extensions/external_install_error.h ('k') | chrome/browser/ui/aura/native_window_tracker_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698