Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Side by Side Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "chrome/browser/extensions/extension_install_prompt.h" 8 #include "chrome/browser/extensions/extension_install_prompt.h"
9 #include "content/public/test/test_browser_thread_bundle.h" 9 #include "content/public/test/test_browser_thread_bundle.h"
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
11 #include "extensions/common/extension_builder.h" 11 #include "extensions/common/extension_builder.h"
12 #include "extensions/common/feature_switch.h" 12 #include "extensions/common/feature_switch.h"
13 #include "extensions/common/permissions/api_permission.h" 13 #include "extensions/common/permissions/api_permission.h"
14 #include "extensions/common/permissions/api_permission_set.h" 14 #include "extensions/common/permissions/api_permission_set.h"
15 #include "extensions/common/permissions/manifest_permission_set.h" 15 #include "extensions/common/permissions/manifest_permission_set.h"
16 #include "extensions/common/permissions/permission_set.h" 16 #include "extensions/common/permissions/permission_set.h"
17 #include "extensions/common/url_pattern_set.h" 17 #include "extensions/common/url_pattern_set.h"
18 #include "extensions/common/value_builder.h" 18 #include "extensions/common/value_builder.h"
19 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
20 20
21 namespace extensions { 21 namespace extensions {
22 22
23 void VerifyPromptPermissionsCallback( 23 void VerifyPromptPermissionsCallback(
24 const base::Closure& quit_closure, 24 const base::Closure& quit_closure,
25 size_t regular_permissions_count, 25 size_t regular_permissions_count,
26 size_t withheld_permissions_count, 26 size_t withheld_permissions_count,
27 const ExtensionInstallPrompt::ShowParams& params, 27 ExtensionInstallPromptShowParams* params,
28 ExtensionInstallPrompt::Delegate* delegate, 28 ExtensionInstallPrompt::Delegate* delegate,
29 scoped_refptr<ExtensionInstallPrompt::Prompt> install_prompt) { 29 scoped_refptr<ExtensionInstallPrompt::Prompt> install_prompt) {
30 ASSERT_TRUE(install_prompt.get()); 30 ASSERT_TRUE(install_prompt.get());
31 EXPECT_EQ(regular_permissions_count, 31 EXPECT_EQ(regular_permissions_count,
32 install_prompt->GetPermissionCount( 32 install_prompt->GetPermissionCount(
33 ExtensionInstallPrompt::REGULAR_PERMISSIONS)); 33 ExtensionInstallPrompt::REGULAR_PERMISSIONS));
34 EXPECT_EQ(withheld_permissions_count, 34 EXPECT_EQ(withheld_permissions_count,
35 install_prompt->GetPermissionCount( 35 install_prompt->GetPermissionCount(
36 ExtensionInstallPrompt::WITHHELD_PERMISSIONS)); 36 ExtensionInstallPrompt::WITHHELD_PERMISSIONS));
37 quit_closure.Run(); 37 quit_closure.Run();
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 NULL, 92 NULL,
93 extension.get(), 93 extension.get(),
94 base::Bind(&VerifyPromptPermissionsCallback, 94 base::Bind(&VerifyPromptPermissionsCallback,
95 run_loop.QuitClosure(), 95 run_loop.QuitClosure(),
96 2u, // |regular_permissions_count|. 96 2u, // |regular_permissions_count|.
97 1u)); // |withheld_permissions_count|. 97 1u)); // |withheld_permissions_count|.
98 run_loop.Run(); 98 run_loop.Run();
99 } 99 }
100 100
101 } // namespace extensions 101 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_install_prompt_show_params.cc ('k') | chrome/browser/extensions/external_install_error.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698