chrome/browser/extensions/external_install_error.h - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_error.h

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt_unittest.cc ('k') | chrome/browser/extensions/external_install_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_error.h

diff --git a/chrome/browser/extensions/external_install_error.h b/chrome/browser/extensions/external_install_error.h

index 395914e615ae851704b81925e7c0c3eac198a46d..c26aa7303b47655685fd71f7cb127b43e052aa83 100644

--- a/chrome/browser/extensions/external_install_error.h

+++ b/chrome/browser/extensions/external_install_error.h

@@ -14,6 +14,7 @@

#include "chrome/browser/extensions/webstore_data_fetcher_delegate.h"

class Browser;

+class ExtensionInstallPromptShowParams;

class ExtensionInstallUI;

class GlobalError;

class GlobalErrorService;

@@ -76,7 +77,7 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,

// Called when the dialog has been successfully populated, and is ready to be

// shown.

- void OnDialogReady(const ExtensionInstallPrompt::ShowParams& show_params,

+ void OnDialogReady(ExtensionInstallPromptShowParams* show_params,

ExtensionInstallPrompt::Delegate* prompt_delegate,

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);

@@ -97,6 +98,7 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,

// The UI for showing the error.

scoped_ptr<ExtensionInstallPrompt> install_ui_;

+ scoped_ptr<ExtensionInstallPromptShowParams> install_ui_show_params_;

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt_;

// The UI for the given error, which will take the form of either a menu