chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_install_dialog_view.h ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index aec29cee932bcdc59598976f5712bfb1d1de8250..b5bb447ea604667fbabed130c10ae1a6bd2fd294 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h"

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_install_prompt_experiment.h"

+#include "chrome/browser/extensions/extension_install_prompt_show_params.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

@@ -168,16 +169,16 @@ CheckboxedView::CheckboxedView(views::View* view,

}

void ShowExtensionInstallDialogImpl(

- const ExtensionInstallPrompt::ShowParams& show_params,

+ ExtensionInstallPromptShowParams* show_params,

ExtensionInstallPrompt::Delegate* delegate,

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

ExtensionInstallDialogView* dialog =

- new ExtensionInstallDialogView(show_params.profile,

- show_params.parent_web_contents,

+ new ExtensionInstallDialogView(show_params->profile(),

+ show_params->GetParentWebContents(),

delegate,

prompt);

- CreateBrowserModalDialogViews(dialog, show_params.parent_window)->Show();

+ CreateBrowserModalDialogViews(dialog, show_params->GetParentWindow())->Show();

}

CustomScrollableView::CustomScrollableView() {}