Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4819)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
index 07a1b5144ba7207ac67ac2248472065ff5a5566c..4330e98d82ba4750fffa13ebdb8b67625cbc79e6 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
@@ -8,6 +8,7 @@
#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h"
#import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h"
#import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
+#include "chrome/browser/extensions/extension_install_prompt_show_params.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "extensions/common/extension.h"
@@ -28,14 +29,14 @@ public:
IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {
content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
- ExtensionInstallPrompt::ShowParams show_params(tab);
+ ExtensionInstallPromptShowParams show_params(tab);
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
ExtensionInstallDialogController* controller =
- new ExtensionInstallDialogController(show_params,
+ new ExtensionInstallDialogController(&show_params,
&delegate,
prompt);
@@ -53,14 +54,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {
IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest,
DISABLED_Permissions) {
content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
- ExtensionInstallPrompt::ShowParams show_params(tab);
+ ExtensionInstallPromptShowParams show_params(tab);
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());
ExtensionInstallDialogController* controller =
- new ExtensionInstallDialogController(show_params,
+ new ExtensionInstallDialogController(&show_params,
&delegate,
prompt);

Powered by Google App Engine
This is Rietveld 408576698