chrome/browser/ui/native_window_tracker_browsertest.cc - Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/native_window_tracker_browsertest.cc

Issue 662073002: Fix crash when user closes window prior to the "Confirm Install" prompt showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/install_prompt_navigator

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/native_window_tracker.h ('K') | « chrome/browser/ui/native_window_tracker.h ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/native_window_tracker.h"

	6

	7 #include "chrome/browser/ui/browser.h"

	8 #include "chrome/browser/ui/browser_window.h"

	9 #include "chrome/test/base/in_process_browser_test.h"

	10 #include "content/public/test/test_utils.h"

	11

	12 typedef InProcessBrowserTest NativeWindowTrackerTest;

	13

	14 IN_PROC_BROWSER_TEST_F(NativeWindowTrackerTest, Basic) {

	15 // Create a second browser to prevent the app from exiting when the browser is

	16 // closed.

	17 CreateBrowser(browser()->profile());

	18

	19 scoped_ptr<NativeWindowTracker> tracker =

	20 NativeWindowTracker::Create(browser()->window()->GetNativeWindow());
	Nico 2014/10/28 17:19:27 nit: maybe add a EXPECT_FALSE(tracker->WasNativ nit: maybe add a EXPECT_FALSE(tracker->WasNativeWindowClosed()); here
	21 browser()->window()->Close();

	22 content::RunAllPendingInMessageLoop();

	23 EXPECT_TRUE(tracker->WasNativeWindowClosed());

	24 }

OLD	NEW