Create helper functions to use in computeInvariantOutput calls

Create helper functions to use in computeInvariantOutput calls

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ccb2e384a036f29d989d3c1468f879324e81a678

[egdaniel, 2014-10-10 17:51:07]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com, robertphillips@google.com

[egdaniel, 2014-10-10 17:51:08]

egdaniel@google.com changed required reviewers:
+ bsalomon@google.com

[egdaniel, 2014-10-10 17:51:08]

So this change cleans up a lot of the calls to onComputeInvariantOutput in each
effect. If you are familiar with any subset of the effects do you please look
over my change to function to see if it makes sense or is there any additional
things to add. Effects missing that can be cleaned up?

Jim and Rob feel free to give l.g.t.m to any subset of effects as only Brian's
lgtm is required by the CQ assuming the * thing is working (plus it touches an
include file anyways).

[bsalomon, 2014-10-10 19:48:17]

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor.h
File include/gpu/GrProcessor.h (right):

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor...
include/gpu/GrProcessor.h:75: void transparentBlackOutput() {
setToTransparentBlack() ?

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor...
include/gpu/GrProcessor.h:81: void unknownOutput() {
setUnknownOutput?

(just trying to avoid confusion about whether these are setters or queries)

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:769: inout->unknownOutput();
I think this can be mulByUnknownAlpha()

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:932: inout->unknownOutput();
and this

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkMagnifier...
File src/effects/SkMagnifierImageFilter.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkMagnifier...
src/effects/SkMagnifierImageFilter.cpp:231:
this->updateInvariantOutputForModulation(inout);
do we still want this function?

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkPerlinNoi...
File src/effects/SkPerlinNoiseShader.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkPerlinNoi...
src/effects/SkPerlinNoiseShader.cpp:590: inout->unknownOutput();
does this generate a random alpha?

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
File src/gpu/effects/GrTextureDomain.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
src/gpu/effects/GrTextureDomain.cpp:274: inout->unknownOutput();
this looks like it could be modulatebyunknowncolor

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
src/gpu/effects/GrTextureDomain.cpp:276:
this->updateInvariantOutputForModulation(inout);
check for opaque config?

[egdaniel, 2014-10-13 16:44:58]

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor.h
File include/gpu/GrProcessor.h (right):

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor...
include/gpu/GrProcessor.h:75: void transparentBlackOutput() {
On 2014/10/10 19:48:16, bsalomon wrote:
> setToTransparentBlack() ?

Done.

https://codereview.chromium.org/643743003/diff/320001/include/gpu/GrProcessor...
include/gpu/GrProcessor.h:81: void unknownOutput() {
On 2014/10/10 19:48:16, bsalomon wrote:
> setUnknownOutput?
> 
> (just trying to avoid confusion about whether these are setters or queries)

Done.

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:769: inout->unknownOutput();
On 2014/10/10 19:48:16, bsalomon wrote:
> I think this can be mulByUnknownAlpha()

Done.

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:932: inout->unknownOutput();
On 2014/10/10 19:48:16, bsalomon wrote:
> and this

Done.

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkMagnifier...
File src/effects/SkMagnifierImageFilter.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkMagnifier...
src/effects/SkMagnifierImageFilter.cpp:231:
this->updateInvariantOutputForModulation(inout);
On 2014/10/10 19:48:16, bsalomon wrote:
> do we still want this function?

So the basic structure of this function is:

if(texture.isOpaque())
 mulByOpaqueColor();
else
 mulByUnknownColor();


This pattern is repeated in all our SingleTextureEffects so I feel like there is
still value to the function.

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkPerlinNoi...
File src/effects/SkPerlinNoiseShader.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/effects/SkPerlinNoi...
src/effects/SkPerlinNoiseShader.cpp:590: inout->unknownOutput();
On 2014/10/10 19:48:16, bsalomon wrote:
> does this generate a random alpha?

It produces a random alpha and returns a vec4 color with each component
multiplied by alpha. It ignores inputColor.

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
File src/gpu/effects/GrTextureDomain.cpp (right):

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
src/gpu/effects/GrTextureDomain.cpp:274: inout->unknownOutput();
On 2014/10/10 19:48:16, bsalomon wrote:
> this looks like it could be modulatebyunknowncolor

Done.

https://codereview.chromium.org/643743003/diff/320001/src/gpu/effects/GrTextu...
src/gpu/effects/GrTextureDomain.cpp:276:
this->updateInvariantOutputForModulation(inout);
On 2014/10/10 19:48:16, bsalomon wrote:
> check for opaque config?

This is checked for in updateInvariantOutputForModulation() see previous comment
on that function

[bsalomon, 2014-10-13 17:56:54]

lgtm

[egdaniel, 2014-10-13 19:36:11]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-10-13 19:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643743003/510001

[commit-bot: I haz the power, 2014-10-13 19:53:52]

Committed patchset #5 (id:510001) as ccb2e384a036f29d989d3c1468f879324e81a678