Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 611383003: Revert of GrResourceCache2 manages scratch texture. (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@surfimpl
Visibility:
Public.

Description

Revert of GrResourceCache2 manages scratch texture. (patchset #14 id:260001 of https://codereview.chromium.org/608883003/) Reason for revert: Turning bots red: Nanobench seems to be uniformly failing on Android (http://108.170.220.21:10117/builders/Perf-Android-Venue8-PowerVR-x86-Release/builds/99/steps/RunNanobench/logs/stdio) Ubuntu GTX660 32bit is failing in both Debug and Release on GM generation (it appears to be out of memory) (http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/builds/2457/steps/GenerateGMs/logs/stdio) Original issue's description: > GrResourceCache2 manages scratch texture. > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3d398c876440deaab39bbf2a9b881c337e6dc8d4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/dbe6074a06efc5fb6883bb5e4f251ed67c8c0ab4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -267 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M gm/texturedomaineffect.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 2 chunks +33 lines, -31 lines 0 comments Download
M include/gpu/GrContext.h View 4 chunks +31 lines, -7 lines 0 comments Download
M include/gpu/GrGpuResource.h View 5 chunks +14 lines, -18 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +15 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +12 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +162 lines, -63 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrResourceCache.h View 4 chunks +57 lines, -8 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 11 chunks +181 lines, -50 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 2 chunks +1 line, -17 lines 0 comments Download
M src/gpu/GrTexture.cpp View 2 chunks +36 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +43 lines, -28 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 3 chunks +10 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 5 chunks +7 lines, -5 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of GrResourceCache2 manages scratch texture.
6 years, 2 months ago (2014-09-30 13:53:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611383003/1
6 years, 2 months ago (2014-09-30 13:54:00 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 13:54:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as dbe6074a06efc5fb6883bb5e4f251ed67c8c0ab4

Powered by Google App Engine
This is Rietveld 408576698