Run clang-modernize -use-nullptr over src/extensions/.

Run clang-modernize -use-nullptr over src/extensions/.

This was generated using the following commands:
ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
cd out/Debug
find ../../extensions -name '*.cc' | xargs -n 16 -P 32 \
~/llvm-build/Release+Asserts/bin/clang-modernize -use-nullptr -p . \
-include extensions -format -style=Chromium

The following files were skipped:
extensions/browser/api/cast_channel/cast_auth_util_openssl.cc
extensions/browser/api/system_cpu/cpu_info_provider_mac.cc
extensions/browser/api/system_cpu/cpu_info_provider_win.cc
extensions/common/extension_api_stub.cc
extensions/common/stack_frame_unittest.cc
extensions/shell/browser/shell_audio_controller_chromeos.cc
extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc
extensions/shell/browser/shell_network_controller_chromeos.cc

BUG=

[Nico, 2014-09-25 05:57:17]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2014-09-25 05:57:20]

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
File extensions/browser/api/bluetooth/bluetooth_apitest.cc (right):

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
extensions/browser/api/bluetooth/bluetooth_apitest.cc:392:
.WillRepeatedly(testing::Return(static_cast<BluetoothDevice*>(nullptr)));
Hmm, is this static_cast still needed with nullptr?

[Sam McNally, 2014-09-25 07:42:38]

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
File extensions/browser/api/bluetooth/bluetooth_apitest.cc (right):

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
extensions/browser/api/bluetooth/bluetooth_apitest.cc:392:
.WillRepeatedly(testing::Return(static_cast<BluetoothDevice*>(nullptr)));
On 2014/09/25 05:57:19, Nico (hiding) wrote:
> Hmm, is this static_cast still needed with nullptr?

Clang on Linux and MSVC are both happy without the static_cast.

[Nico, 2014-09-25 19:33:41]

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
File extensions/browser/api/bluetooth/bluetooth_apitest.cc (right):

https://codereview.chromium.org/598173003/diff/1/extensions/browser/api/bluet...
extensions/browser/api/bluetooth/bluetooth_apitest.cc:392:
.WillRepeatedly(testing::Return(static_cast<BluetoothDevice*>(nullptr)));
On 2014/09/25 07:42:38, Sam McNally wrote:
> On 2014/09/25 05:57:19, Nico (hiding) wrote:
> > Hmm, is this static_cast still needed with nullptr?
> 
> Clang on Linux and MSVC are both happy without the static_cast.

Hm, maybe we can contribute a patch to clang-modernize to strip out unnecessary
casts of NULL when converting to nullptr?