extensions/common/manifest_handlers/file_handler_manifest_unittest.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/common/manifest_handlers/file_handler_info.cc ('k') | extensions/common/manifest_handlers/icons_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

diff --git a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

index 5934dc094996affb63ba53c9bbb27acf7419ceeb..fcd1e7e59531907d650af1d3b8e3098320226f8f 100644

--- a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

+++ b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

@@ -40,7 +40,7 @@ TEST_F(FileHandlersManifestTest, ValidFileHandlers) {

ASSERT_TRUE(extension.get());

const FileHandlersInfo* handlers =

FileHandlers::GetFileHandlers(extension.get());

- ASSERT_TRUE(handlers != NULL);

+ ASSERT_TRUE(handlers != nullptr);

ASSERT_EQ(2U, handlers->size());

FileHandlerInfo handler = handlers->at(0);

@@ -66,7 +66,7 @@ TEST_F(FileHandlersManifestTest, NotPlatformApp) {

ASSERT_TRUE(extension.get());

const FileHandlersInfo* handlers =

FileHandlers::GetFileHandlers(extension.get());

- ASSERT_TRUE(handlers == NULL);

+ ASSERT_TRUE(handlers == nullptr);

}

} // namespace extensions