extensions/common/permissions/socket_permission_unittest.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/socket_permission_unittest.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/common/permissions/settings_override_permission.cc ('k') | extensions/common/permissions/usb_device_permission_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/socket_permission_unittest.cc

diff --git a/extensions/common/permissions/socket_permission_unittest.cc b/extensions/common/permissions/socket_permission_unittest.cc

index 0b1fae02dc954609b4d0034019ee5459662291ba..7514b9152fdb5b4a4e0f551e241154c2ba37df99 100644

--- a/extensions/common/permissions/socket_permission_unittest.cc

+++ b/extensions/common/permissions/socket_permission_unittest.cc

@@ -293,7 +293,7 @@ TEST(SocketPermissionTest, IPC) {

value->AppendString("tcp-connect:*.example.com:80");

value->AppendString("udp-bind::8080");

value->AppendString("udp-send-to::8888");

- ASSERT_TRUE(permission1->FromValue(value.get(), NULL, NULL));

+ ASSERT_TRUE(permission1->FromValue(value.get(), nullptr, NULL));

EXPECT_FALSE(permission1->Equal(permission2.get()));

@@ -315,13 +315,13 @@ TEST(SocketPermissionTest, Value) {

value->AppendString("tcp-connect:*.example.com:80");

value->AppendString("udp-bind::8080");

value->AppendString("udp-send-to::8888");

- ASSERT_TRUE(permission1->FromValue(value.get(), NULL, NULL));

+ ASSERT_TRUE(permission1->FromValue(value.get(), nullptr, NULL));

EXPECT_FALSE(permission1->Equal(permission2.get()));

scoped_ptr<base::Value> vtmp(permission1->ToValue());

ASSERT_TRUE(vtmp);

- ASSERT_TRUE(permission2->FromValue(vtmp.get(), NULL, NULL));

+ ASSERT_TRUE(permission2->FromValue(vtmp.get(), nullptr, NULL));

EXPECT_TRUE(permission1->Equal(permission2.get()));

}