extensions/browser/api/declarative/deduping_factory_unittest.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/deduping_factory_unittest.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/browser/api/declarative/declarative_rule_unittest.cc ('k') | extensions/browser/api/declarative/rules_cache_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/deduping_factory_unittest.cc

diff --git a/extensions/browser/api/declarative/deduping_factory_unittest.cc b/extensions/browser/api/declarative/deduping_factory_unittest.cc

index 73d0a4b637da9a62fb9201a427122a3823f8f231..319c881d5497dcce80598e1d9156e943a1c44d19 100644

--- a/extensions/browser/api/declarative/deduping_factory_unittest.cc

+++ b/extensions/browser/api/declarative/deduping_factory_unittest.cc

@@ -59,13 +59,13 @@ scoped_refptr<const BaseClass> CreateFoo(const std::string& /*instance_type*/,

const base::Value* value,

std::string* error,

bool* bad_message) {

- const base::DictionaryValue* dict = NULL;

+ const base::DictionaryValue* dict = nullptr;

CHECK(value->GetAsDictionary(&dict));

int parameter = 0;

if (!dict->GetInteger("parameter", &parameter)) {

*error = "No parameter";

*bad_message = true;

- return scoped_refptr<const BaseClass>(NULL);

+ return scoped_refptr<const BaseClass>(nullptr);

}

return scoped_refptr<const BaseClass>(new Foo(parameter));

}