extensions/browser/api/cast_channel/cast_auth_util_nss.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_auth_util_nss.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/browser/api/capture_web_contents_function.cc ('k') | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_auth_util_nss.cc

diff --git a/extensions/browser/api/cast_channel/cast_auth_util_nss.cc b/extensions/browser/api/cast_channel/cast_auth_util_nss.cc

index a3fc24dffd24747fe76dd35d2628f02acf388169..dfe8fdffd671e75dce7e41a9046a399b2d26bb52 100644

--- a/extensions/browser/api/cast_channel/cast_auth_util_nss.cc

+++ b/extensions/browser/api/cast_channel/cast_auth_util_nss.cc

@@ -676,7 +676,7 @@ AuthResult VerifyCredentials(const AuthResponse& response,

// Parse into a certificate structure.

ScopedCERTCertificate cert(CERT_NewTempCertificate(

- CERT_GetDefaultCertDB(), &der_cert, NULL, PR_FALSE, PR_TRUE));

+ CERT_GetDefaultCertDB(), &der_cert, nullptr, PR_FALSE, PR_TRUE));

if (!cert.get()) {

return AuthResult::CreateWithNSSError(

kErrorPrefix + "Failed to parse certificate.",

@@ -692,7 +692,7 @@ AuthResult VerifyCredentials(const AuthResponse& response,

SECKEY_ImportDERPublicKey(

const_cast<SECItem*>(trusted_ca_key_der), CKK_RSA));

SECStatus verified = CERT_VerifySignedDataWithPublicKey(

- &cert->signatureWrap, ca_public_key.get(), NULL);

+ &cert->signatureWrap, ca_public_key.get(), nullptr);

if (verified != SECSuccess) {

return AuthResult::CreateWithNSSError(

kErrorPrefix + "Cert not signed by trusted CA",

@@ -721,7 +721,9 @@ AuthResult VerifyCredentials(const AuthResponse& response,

public_key.get(),

&signature_item,

SEC_OID_PKCS1_RSA_ENCRYPTION,

- SEC_OID_SHA1, NULL, NULL);

+ SEC_OID_SHA1,

+ nullptr,

+ nullptr);

if (verified != SECSuccess) {

return AuthResult::CreateWithNSSError(