extensions/browser/api/declarative/rules_cache_delegate.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_cache_delegate.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/browser/api/declarative/deduping_factory_unittest.cc ('k') | extensions/browser/api/declarative/rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/rules_cache_delegate.cc

diff --git a/extensions/browser/api/declarative/rules_cache_delegate.cc b/extensions/browser/api/declarative/rules_cache_delegate.cc

index 03a4b497b39d6928fe661e7b8c725a58f00c59cf..641ff9e0f26e96b5bf7f0549131eb716ce50cded 100644

--- a/extensions/browser/api/declarative/rules_cache_delegate.cc

+++ b/extensions/browser/api/declarative/rules_cache_delegate.cc

@@ -37,7 +37,7 @@ const char RulesCacheDelegate::kRulesStoredKey[] =

"has_declarative_rules";

RulesCacheDelegate::RulesCacheDelegate(bool log_storage_init_delay)

- : browser_context_(NULL),

+ : browser_context_(nullptr),

log_storage_init_delay_(log_storage_init_delay),

notified_registry_(false),

weak_ptr_factory_(this) {

@@ -97,7 +97,7 @@ void RulesCacheDelegate::WriteToStorage(const std::string& extension_id,

if (!browser_context_)

return;

- const base::ListValue* rules = NULL;

+ const base::ListValue* rules = nullptr;

CHECK(value->GetAsList(&rules));

bool rules_stored_previously = GetDeclarativeRulesStored(extension_id);

bool store_rules = !rules->empty();