Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: extensions/renderer/script_context_set_unittest.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "extensions/common/extension.h" 6 #include "extensions/common/extension.h"
7 #include "extensions/common/features/feature.h" 7 #include "extensions/common/features/feature.h"
8 #include "extensions/renderer/script_context.h" 8 #include "extensions/renderer/script_context.h"
9 #include "extensions/renderer/script_context_set.h" 9 #include "extensions/renderer/script_context_set.h"
10 #include "gin/public/context_holder.h" 10 #include "gin/public/context_holder.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "third_party/WebKit/public/web/WebFrame.h" 12 #include "third_party/WebKit/public/web/WebFrame.h"
13 #include "v8/include/v8.h" 13 #include "v8/include/v8.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 16
17 TEST(ScriptContextSet, Lifecycle) { 17 TEST(ScriptContextSet, Lifecycle) {
18 base::MessageLoop loop; 18 base::MessageLoop loop;
19 19
20 ScriptContextSet context_set; 20 ScriptContextSet context_set;
21 21
22 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 22 v8::Isolate* isolate = v8::Isolate::GetCurrent();
23 v8::HandleScope handle_scope(isolate); 23 v8::HandleScope handle_scope(isolate);
24 gin::ContextHolder context_holder(isolate); 24 gin::ContextHolder context_holder(isolate);
25 context_holder.SetContext(v8::Context::New(isolate)); 25 context_holder.SetContext(v8::Context::New(isolate));
26 26
27 // Dirty hack, but we don't actually need the frame, and this is easier than 27 // Dirty hack, but we don't actually need the frame, and this is easier than
28 // creating a whole webview. 28 // creating a whole webview.
29 blink::WebFrame* frame = reinterpret_cast<blink::WebFrame*>(1); 29 blink::WebFrame* frame = reinterpret_cast<blink::WebFrame*>(1);
30 const Extension* extension = NULL; 30 const Extension* extension = nullptr;
31 ScriptContext* context = 31 ScriptContext* context =
32 new ScriptContext(context_holder.context(), 32 new ScriptContext(context_holder.context(),
33 frame, 33 frame,
34 extension, 34 extension,
35 Feature::BLESSED_EXTENSION_CONTEXT, 35 Feature::BLESSED_EXTENSION_CONTEXT,
36 extension, 36 extension,
37 Feature::BLESSED_EXTENSION_CONTEXT); 37 Feature::BLESSED_EXTENSION_CONTEXT);
38 38
39 context_set.Add(context); 39 context_set.Add(context);
40 EXPECT_EQ(1u, context_set.GetAll().count(context)); 40 EXPECT_EQ(1u, context_set.GetAll().count(context));
(...skipping 13 matching lines...) Expand all
54 EXPECT_EQ(1u, set_copy.size()); 54 EXPECT_EQ(1u, set_copy.size());
55 55
56 // After removal, the context should be marked for destruction. 56 // After removal, the context should be marked for destruction.
57 EXPECT_FALSE(context->web_frame()); 57 EXPECT_FALSE(context->web_frame());
58 58
59 // Run loop to do the actual deletion. 59 // Run loop to do the actual deletion.
60 loop.RunUntilIdle(); 60 loop.RunUntilIdle();
61 } 61 }
62 62
63 } // namespace extensions 63 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698