Run clang-modernize -use-nullptr over src/extensions/.

extensions/common/file_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/file_util.h"
 
 #include "base/basictypes.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 26 matching lines @@
   return extension;
 }
 
 scoped_refptr<Extension> LoadExtensionManifest(
     const std::string& manifest_value,
     const base::FilePath& manifest_dir,
     Manifest::Location location,
     int extra_flags,
     std::string* error) {
   JSONStringValueSerializer serializer(manifest_value);
-  scoped_ptr<base::Value> result(serializer.Deserialize(NULL, error));
+  scoped_ptr<base::Value> result(serializer.Deserialize(nullptr, error));
   if (!result.get())
-    return NULL;
+    return nullptr;
   CHECK_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
   return LoadExtensionManifest(
       static_cast<base::DictionaryValue*>(result.get()),
       manifest_dir,
       location,
       extra_flags,
       error);
 }
 
 }  // namespace
@@ skipping 55 matching lines @@
 }
 
 TEST_F(FileUtilTest, LoadExtensionWithValidLocales) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir = install_dir.AppendASCII("extension_with_locales");
 
   std::string error;
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       install_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
-  ASSERT_TRUE(extension.get() != NULL);
+  ASSERT_TRUE(extension.get() != nullptr);
   EXPECT_EQ("The first extension that I made.", extension->description());
 }
 
 TEST_F(FileUtilTest, LoadExtensionWithoutLocalesFolder) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir = install_dir.AppendASCII("extension_without_locales");
 
   std::string error;
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       install_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
-  ASSERT_FALSE(extension.get() == NULL);
+  ASSERT_FALSE(extension.get() == nullptr);
   EXPECT_TRUE(error.empty());
 }
 
 TEST_F(FileUtilTest, CheckIllegalFilenamesNoUnderscores) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().AppendASCII("some_dir");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
@@ skipping 36 matching lines @@
 
 TEST_F(FileUtilTest, LoadExtensionGivesHelpfullErrorOnMissingManifest) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir =
       install_dir.AppendASCII("file_util").AppendASCII("missing_manifest");
 
   std::string error;
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       install_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
-  ASSERT_TRUE(extension.get() == NULL);
+  ASSERT_TRUE(extension.get() == nullptr);
   ASSERT_FALSE(error.empty());
   ASSERT_STREQ("Manifest file is missing or unreadable.", error.c_str());
 }
 
 TEST_F(FileUtilTest, LoadExtensionGivesHelpfullErrorOnBadManifest) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir =
       install_dir.AppendASCII("file_util").AppendASCII("bad_manifest");
 
   std::string error;
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       install_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
-  ASSERT_TRUE(extension.get() == NULL);
+  ASSERT_TRUE(extension.get() == nullptr);
   ASSERT_FALSE(error.empty());
   ASSERT_STREQ(
       "Manifest is not valid JSON.  "
       "Line: 2, column: 16, Syntax error.",
       error.c_str());
 }
 
 TEST_F(FileUtilTest, ValidateThemeUTF8) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
@@ skipping 163 matching lines @@
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
 
   // Try to install an extension with a zero-length icon file.
   base::FilePath ext_dir =
       install_dir.AppendASCII("file_util").AppendASCII("bad_icon");
 
   std::string error;
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       ext_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
-  EXPECT_TRUE(extension.get() == NULL);
+  EXPECT_TRUE(extension.get() == nullptr);
   EXPECT_STREQ("Could not load extension icon 'icon.png'.", error.c_str());
 }
 
 TEST_F(FileUtilTest, ExtensionURLToRelativeFilePath) {
 #define URL_PREFIX "chrome-extension://extension-id/"
   struct TestCase {
     const char* url;
     const char* expected_relative_path;
   } test_cases[] = {
     { URL_PREFIX "simple.html",
@@ skipping 52 matching lines @@
 #ifdef FILE_PATH_USES_WIN_SEPARATORS
 #define SEP "\\"
 #else
 #define SEP "/"
 #endif
 #define URL_PREFIX "chrome-extension-resource://"
   struct TestCase {
     const char* url;
     const base::FilePath::CharType* expected_path;
   } test_cases[] = {
-    { URL_PREFIX "apiname/test.js",
-      FILE_PATH_LITERAL("test.js") },
-    { URL_PREFIX "/apiname/test.js",
-      FILE_PATH_LITERAL("test.js") },
-    // Test % escape
-    { URL_PREFIX "apiname/%74%65st.js",
-      FILE_PATH_LITERAL("test.js") },
-    { URL_PREFIX "apiname/escape%20spaces.js",
-      FILE_PATH_LITERAL("escape spaces.js") },
-    // Test file does not exist.
-    { URL_PREFIX "apiname/directory/to/file.js",
-      NULL },
-    // Test apiname/../../test.js
-    { URL_PREFIX "apiname/../../test.js",
-      FILE_PATH_LITERAL("test.js") },
-    { URL_PREFIX "apiname/..%2F../test.js",
-      NULL },
-    { URL_PREFIX "apiname/f/../../../test.js",
-      FILE_PATH_LITERAL("test.js") },
-    { URL_PREFIX "apiname/f%2F..%2F..%2F../test.js",
-      NULL },
-  };
+        {URL_PREFIX "apiname/test.js", FILE_PATH_LITERAL("test.js")},
+        {URL_PREFIX "/apiname/test.js", FILE_PATH_LITERAL("test.js")},
+        // Test % escape
+        {URL_PREFIX "apiname/%74%65st.js", FILE_PATH_LITERAL("test.js")},
+        {URL_PREFIX "apiname/escape%20spaces.js",
+         FILE_PATH_LITERAL("escape spaces.js")},
+        // Test file does not exist.
+        {URL_PREFIX "apiname/directory/to/file.js", nullptr},
+        // Test apiname/../../test.js
+        {URL_PREFIX "apiname/../../test.js", FILE_PATH_LITERAL("test.js")},
+        {URL_PREFIX "apiname/..%2F../test.js", nullptr},
+        {URL_PREFIX "apiname/f/../../../test.js", FILE_PATH_LITERAL("test.js")},
+        {URL_PREFIX "apiname/f%2F..%2F..%2F../test.js", nullptr},
+    };
 #undef SEP
 #undef URL_PREFIX
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     GURL url(test_cases[i].url);
     base::FilePath expected_path;
     if (test_cases[i].expected_path)
       expected_path = root_path.Append(FILE_PATH_LITERAL("apiname")).Append(
           test_cases[i].expected_path);
     base::FilePath actual_path =
         extensions::file_util::ExtensionResourceURLToFilePath(url, root_path);
     EXPECT_EQ(expected_path.value(), actual_path.value()) <<
       " For the path " << url;
   }
   // Remove temp files.
   ASSERT_TRUE(base::DeleteFile(root_path, true));
 }
 
 }  // namespace extensions