extensions/common/features/simple_feature.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/simple_feature.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/common/features/json_feature_provider_source.cc ('k') | extensions/common/file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/simple_feature.cc

diff --git a/extensions/common/features/simple_feature.cc b/extensions/common/features/simple_feature.cc

index e623bcf47d7661c48a2080f85d590f3b9cfc0a48..f307118665fe5690e0e5402426dd63ffcec0dd85 100644

--- a/extensions/common/features/simple_feature.cc

+++ b/extensions/common/features/simple_feature.cc

@@ -80,7 +80,7 @@ base::LazyInstance<Mappings> g_mappings = LAZY_INSTANCE_INITIALIZER;

void ParseSet(const base::DictionaryValue* value,

const std::string& property,

std::set<std::string>* set) {

- const base::ListValue* list_value = NULL;

+ const base::ListValue* list_value = nullptr;

if (!value->GetList(property, &list_value))

return;

@@ -155,7 +155,7 @@ void ParseEnumSet(const base::DictionaryValue* value,

void ParseURLPatterns(const base::DictionaryValue* value,

const std::string& key,

URLPatternSet* set) {

- const base::ListValue* matches = NULL;

+ const base::ListValue* matches = nullptr;

if (value->GetList(key, &matches)) {

set->ClearPatterns();

for (size_t i = 0; i < matches->GetSize(); ++i) {