Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed)

Created:
6 years, 3 months ago by nshaik
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, shishir+watch_chromium.org, browser-components-watch_chromium.org, haitaol+watch_chromium.org, dominich+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Eliminate NOTIFICATION_HISTORY_LOADED notification - add HistoryServiceLoaded method to HistoryServiceObserver - invoke observer methods instead of sending notification BUG=373322 TEST=unit_tests Committed: https://crrev.com/793ee5bff54aa3cb1c1873dfeeeb1f36c42e810f Cr-Commit-Position: refs/heads/master@{#306027}

Patch Set 1 #

Total comments: 49

Patch Set 2 : Address review comments #

Total comments: 32

Patch Set 3 : Fixed styling issues #

Total comments: 10

Patch Set 4 : Clean up of code in ResourcePrefetchPredictor #

Total comments: 8

Patch Set 5 : clean up bookmark_data_type_controller #

Total comments: 10

Patch Set 6 : Fix Clean up state in bookmark_data_type_controller #

Total comments: 2

Patch Set 7 : Add HistoryServiceBeingDeleted to HistoryServiceObserver #

Total comments: 2

Patch Set 8 : Listen HistoryServiceBeingDeleted in LastDownloadFinder for cleanup #

Total comments: 28

Patch Set 9 : Move HistoryServiceObserver functions to private #

Total comments: 10

Patch Set 10 : Address review comments in historymenubridge #

Patch Set 11 : Remove bookmark_model as member variable #

Total comments: 2

Patch Set 12 : Fixed a nit in last_download_finder #

Patch Set 13 : Rebase changes #

Patch Set 14 : Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -199 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -5 lines 1 comment Download
M chrome/browser/history/history_service.h View 1 2 3 4 5 6 7 8 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 2 3 4 5 6 7 8 7 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.h View 1 2 3 4 5 6 7 8 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 2 3 4 5 6 7 8 4 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 2 3 4 5 6 7 8 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 3 4 5 6 7 8 5 chunks +28 lines, -21 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder.h View 1 2 3 4 5 6 7 8 4 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/search_engines/chrome_template_url_service_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/chrome_template_url_service_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +33 lines, -43 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +17 lines, -33 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +14 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +40 lines, -8 lines 0 comments Download
M components/history/core/browser/history_service_observer.h View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 77 (22 generated)
nshaik
On 2014/09/18 01:10:32, naiem.shaik wrote: > mailto:naiem.shaik@gmail.com changed reviewers: > + mailto:sdefresne@chromium.org @sdefresne PTAL, i ...
6 years, 3 months ago (2014-09-20 15:58:12 UTC) #2
sdefresne
https://codereview.chromium.org/573553004/diff/1/chrome/browser/history/history_service.h File chrome/browser/history/history_service.h (right): https://codereview.chromium.org/573553004/diff/1/chrome/browser/history/history_service.h#newcode522 chrome/browser/history/history_service.h:522: Profile* profile() { return profile_; } We'll have to ...
6 years, 3 months ago (2014-09-23 08:45:10 UTC) #3
nshaik
Sylvain, Thanks for your comments. I have one question, in chrome/browser/history/in_memory_url_index.cc: The code I have ...
6 years, 2 months ago (2014-10-09 18:41:46 UTC) #4
sdefresne
On 2014/10/09 18:41:46, naiem.shaik wrote: > Sylvain, > Thanks for your comments. > I have ...
6 years, 2 months ago (2014-10-10 14:59:44 UTC) #5
sdefresne
On 2014/10/10 14:59:44, sdefresne wrote: > On 2014/10/09 18:41:46, naiem.shaik wrote: > > Sylvain, > ...
6 years, 2 months ago (2014-10-10 15:01:20 UTC) #6
nshaik
On 2014/10/10 15:01:20, sdefresne wrote: > On 2014/10/10 14:59:44, sdefresne wrote: > > On 2014/10/09 ...
6 years, 2 months ago (2014-10-13 22:28:56 UTC) #7
sdefresne
I did review the code, and in particular how you switched the classes to use ...
6 years, 2 months ago (2014-10-20 13:15:43 UTC) #8
nshaik
PTAL https://codereview.chromium.org/573553004/diff/1/chrome/browser/history/history_service.cc File chrome/browser/history/history_service.cc (right): https://codereview.chromium.org/573553004/diff/1/chrome/browser/history/history_service.cc#newcode1230 chrome/browser/history/history_service.cc:1230: void HistoryService::AddHistoryServiceObserver( On 2014/10/20 13:15:41, sdefresne wrote: > ...
6 years, 1 month ago (2014-10-29 08:43:40 UTC) #9
sdefresne
https://codereview.chromium.org/573553004/diff/60001/chrome/browser/history/in_memory_url_index.h File chrome/browser/history/in_memory_url_index.h (right): https://codereview.chromium.org/573553004/diff/60001/chrome/browser/history/in_memory_url_index.h#newcode249 chrome/browser/history/in_memory_url_index.h:249: virtual void OnHistoryServiceLoaded(HistoryService* history_service) override; style: Chromium style changed ...
6 years, 1 month ago (2014-10-30 17:37:04 UTC) #10
nshaik
PTAL https://codereview.chromium.org/573553004/diff/60001/chrome/browser/history/in_memory_url_index.h File chrome/browser/history/in_memory_url_index.h (right): https://codereview.chromium.org/573553004/diff/60001/chrome/browser/history/in_memory_url_index.h#newcode249 chrome/browser/history/in_memory_url_index.h:249: virtual void OnHistoryServiceLoaded(HistoryService* history_service) override; On 2014/10/30 17:37:03, ...
6 years, 1 month ago (2014-10-30 21:48:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/80001
6 years, 1 month ago (2014-10-31 03:57:15 UTC) #14
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-31 03:57:19 UTC) #16
nshaik
@sdefresne,sky, PTAL: @sky: chrome/browser/chrome_notification_types.h chrome/browser/predictors/autocomplete_action_predictor.cc chrome/browser/predictors/autocomplete_action_predictor.h chrome/browser/predictors/resource_prefetch_predictor.cc chrome/browser/predictors/resource_prefetch_predictor.h chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc chrome/browser/safe_browsing/incident_reporting/last_download_finder.h chrome/browser/sync/glue/bookmark_data_type_controller.cc chrome/browser/sync/glue/bookmark_data_type_controller.h chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc chrome/browser/ui/cocoa/history_menu_bridge.h chrome/browser/ui/cocoa/history_menu_bridge.mm ...
6 years, 1 month ago (2014-10-31 17:52:26 UTC) #18
sky
sky->brettw
6 years, 1 month ago (2014-10-31 18:06:01 UTC) #20
nshaik
On 2014/10/31 18:06:01, sky wrote: > sky->brettw PTAL.
6 years, 1 month ago (2014-11-03 18:42:32 UTC) #21
sdefresne
Just one comment and some nits. This is starting to look good. https://codereview.chromium.org/573553004/diff/80001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc ...
6 years, 1 month ago (2014-11-03 19:14:13 UTC) #22
nshaik
@sdefresne, Thanks for your comments. PTAL. https://codereview.chromium.org/573553004/diff/80001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/573553004/diff/80001/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode1212 chrome/browser/predictors/resource_prefetch_predictor.cc:1212: HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS); On ...
6 years, 1 month ago (2014-11-04 00:13:05 UTC) #23
sdefresne
Sorry, I missed an issue in my previous review. https://codereview.chromium.org/573553004/diff/100001/chrome/browser/history/history_service.h File chrome/browser/history/history_service.h (right): https://codereview.chromium.org/573553004/diff/100001/chrome/browser/history/history_service.h#newcode854 chrome/browser/history/history_service.h:854: ...
6 years, 1 month ago (2014-11-04 14:12:29 UTC) #24
nshaik
PTAL. https://codereview.chromium.org/573553004/diff/100001/chrome/browser/history/history_service.h File chrome/browser/history/history_service.h (right): https://codereview.chromium.org/573553004/diff/100001/chrome/browser/history/history_service.h#newcode854 chrome/browser/history/history_service.h:854: // TODO(sdefresne): remove this method. On 2014/11/04 14:12:29, ...
6 years, 1 month ago (2014-11-04 21:20:28 UTC) #25
sdefresne
https://codereview.chromium.org/573553004/diff/120001/chrome/browser/history/in_memory_url_index.cc File chrome/browser/history/in_memory_url_index.cc (right): https://codereview.chromium.org/573553004/diff/120001/chrome/browser/history/in_memory_url_index.cc#newcode305 chrome/browser/history/in_memory_url_index.cc:305: history_service_observer_.Add(service); InMemoryURLIndex constructor already register 'this' as an observer, ...
6 years, 1 month ago (2014-11-05 14:51:52 UTC) #26
nshaik
PTAL https://codereview.chromium.org/573553004/diff/120001/chrome/browser/history/in_memory_url_index.cc File chrome/browser/history/in_memory_url_index.cc (right): https://codereview.chromium.org/573553004/diff/120001/chrome/browser/history/in_memory_url_index.cc#newcode305 chrome/browser/history/in_memory_url_index.cc:305: history_service_observer_.Add(service); On 2014/11/05 14:51:52, sdefresne wrote: > InMemoryURLIndex ...
6 years, 1 month ago (2014-11-06 02:05:13 UTC) #27
sdefresne
https://codereview.chromium.org/573553004/diff/140001/chrome/browser/sync/glue/bookmark_data_type_controller.cc File chrome/browser/sync/glue/bookmark_data_type_controller.cc (right): https://codereview.chromium.org/573553004/diff/140001/chrome/browser/sync/glue/bookmark_data_type_controller.cc#newcode39 chrome/browser/sync/glue/bookmark_data_type_controller.cc:39: notification_registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED, Another option would be to add a ...
6 years, 1 month ago (2014-11-07 16:39:42 UTC) #28
nshaik
PTAL. https://codereview.chromium.org/573553004/diff/140001/chrome/browser/sync/glue/bookmark_data_type_controller.cc File chrome/browser/sync/glue/bookmark_data_type_controller.cc (right): https://codereview.chromium.org/573553004/diff/140001/chrome/browser/sync/glue/bookmark_data_type_controller.cc#newcode39 chrome/browser/sync/glue/bookmark_data_type_controller.cc:39: notification_registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED, On 2014/11/07 16:39:42, sdefresne wrote: > ...
6 years, 1 month ago (2014-11-07 23:45:33 UTC) #29
sdefresne
LGTM brettw: can you also have a look, it's a complex refactoring, and I'd prefer ...
6 years, 1 month ago (2014-11-08 15:16:42 UTC) #30
nshaik
@brettw, PTAL. https://codereview.chromium.org/573553004/diff/160001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc File chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc (right): https://codereview.chromium.org/573553004/diff/160001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc#newcode253 chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc:253: if (history_service) On 2014/11/08 15:16:42, sdefresne wrote: ...
6 years, 1 month ago (2014-11-09 09:21:16 UTC) #31
nshaik
@brettw, PTAL.
6 years, 1 month ago (2014-11-13 01:26:30 UTC) #32
nshaik
PTAL. phajdan.jr: chrome/test/ thakis: chrome/browser/predictors/ mattm: chrome/browser/safe_browsing/ atwilson: chrome/browser/sync/ pkasting: chrome/browser/ui/
6 years, 1 month ago (2014-11-14 18:26:48 UTC) #34
brettw
https://codereview.chromium.org/573553004/diff/180001/chrome/browser/history/in_memory_url_index.cc File chrome/browser/history/in_memory_url_index.cc (right): https://codereview.chromium.org/573553004/diff/180001/chrome/browser/history/in_memory_url_index.cc#newcode305 chrome/browser/history/in_memory_url_index.cc:305: !history_service_observer_.IsObserving(service)) { Are you sure you want to change ...
6 years, 1 month ago (2014-11-14 21:13:07 UTC) #35
nshaik
brettw: Thanks for your comments. PTAL. https://codereview.chromium.org/573553004/diff/180001/chrome/browser/history/in_memory_url_index.cc File chrome/browser/history/in_memory_url_index.cc (right): https://codereview.chromium.org/573553004/diff/180001/chrome/browser/history/in_memory_url_index.cc#newcode305 chrome/browser/history/in_memory_url_index.cc:305: !history_service_observer_.IsObserving(service)) { On ...
6 years, 1 month ago (2014-11-15 07:04:16 UTC) #36
brettw
lgtm
6 years, 1 month ago (2014-11-16 05:42:21 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/200001
6 years, 1 month ago (2014-11-16 08:27:28 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6083)
6 years, 1 month ago (2014-11-16 09:34:07 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/200001
6 years, 1 month ago (2014-11-16 22:10:45 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6111)
6 years, 1 month ago (2014-11-16 23:15:29 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/200001
6 years, 1 month ago (2014-11-17 00:07:07 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6118)
6 years, 1 month ago (2014-11-17 01:12:23 UTC) #49
Andrew T Wilson (Slow)
LG, but adding zea@ in case he wants to review since I'm only passingly familiar ...
6 years, 1 month ago (2014-11-17 10:27:00 UTC) #51
Paweł Hajdan Jr.
chrome/test LGTM
6 years, 1 month ago (2014-11-17 10:35:56 UTC) #52
Peter Kasting
c/b/ui LGTM https://codereview.chromium.org/573553004/diff/200001/chrome/browser/ui/cocoa/history_menu_bridge.mm File chrome/browser/ui/cocoa/history_menu_bridge.mm (right): https://codereview.chromium.org/573553004/diff/200001/chrome/browser/ui/cocoa/history_menu_bridge.mm#newcode78 chrome/browser/ui/cocoa/history_menu_bridge.mm:78: if (hs && hs->BackendLoaded()) { Nit: Longer, ...
6 years, 1 month ago (2014-11-17 18:45:32 UTC) #53
nshaik
@pkasting, Thanks for your comments. PTAL. https://codereview.chromium.org/573553004/diff/200001/chrome/browser/ui/cocoa/history_menu_bridge.mm File chrome/browser/ui/cocoa/history_menu_bridge.mm (right): https://codereview.chromium.org/573553004/diff/200001/chrome/browser/ui/cocoa/history_menu_bridge.mm#newcode78 chrome/browser/ui/cocoa/history_menu_bridge.mm:78: if (hs && ...
6 years, 1 month ago (2014-11-17 23:24:29 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/220001
6 years, 1 month ago (2014-11-17 23:26:01 UTC) #56
Peter Kasting
Still LGTM
6 years, 1 month ago (2014-11-17 23:26:03 UTC) #57
Nicolas Zea
sync LGTM with a request https://codereview.chromium.org/573553004/diff/200001/chrome/browser/sync/glue/bookmark_data_type_controller.cc File chrome/browser/sync/glue/bookmark_data_type_controller.cc (right): https://codereview.chromium.org/573553004/diff/200001/chrome/browser/sync/glue/bookmark_data_type_controller.cc#newcode46 chrome/browser/sync/glue/bookmark_data_type_controller.cc:46: bookmark_model_ = BookmarkModelFactory::GetForProfile(profile_); nit: ...
6 years, 1 month ago (2014-11-17 23:59:50 UTC) #58
nshaik
@zea, Thanks for your comments. PTAL. https://codereview.chromium.org/573553004/diff/200001/chrome/browser/sync/glue/bookmark_data_type_controller.cc File chrome/browser/sync/glue/bookmark_data_type_controller.cc (right): https://codereview.chromium.org/573553004/diff/200001/chrome/browser/sync/glue/bookmark_data_type_controller.cc#newcode46 chrome/browser/sync/glue/bookmark_data_type_controller.cc:46: bookmark_model_ = BookmarkModelFactory::GetForProfile(profile_); ...
6 years, 1 month ago (2014-11-18 00:53:25 UTC) #60
mattm
safe_browsing lgtm with nit https://codereview.chromium.org/573553004/diff/240001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc File chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc (right): https://codereview.chromium.org/573553004/diff/240001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc#newcode200 chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc:200: // waiting for OnHistoryServiceLoaded.. nit: ...
6 years, 1 month ago (2014-11-18 02:19:55 UTC) #61
nshaik
@mattm, Thanks. fixed the nit. https://codereview.chromium.org/573553004/diff/240001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc File chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc (right): https://codereview.chromium.org/573553004/diff/240001/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc#newcode200 chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc:200: // waiting for OnHistoryServiceLoaded.. ...
6 years, 1 month ago (2014-11-18 03:10:57 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/260001
6 years, 1 month ago (2014-11-18 14:40:16 UTC) #64
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6579)
6 years, 1 month ago (2014-11-18 15:21:09 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/280001
6 years, 1 month ago (2014-11-24 01:11:34 UTC) #68
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/8485)
6 years, 1 month ago (2014-11-24 02:27:17 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573553004/300001
6 years ago (2014-11-27 20:31:14 UTC) #72
Avi (use Gerrit)
\o/ https://codereview.chromium.org/573553004/diff/300001/chrome/browser/chrome_notification_types.h File chrome/browser/chrome_notification_types.h (left): https://codereview.chromium.org/573553004/diff/300001/chrome/browser/chrome_notification_types.h#oldcode236 chrome/browser/chrome_notification_types.h:236: NOTIFICATION_HISTORY_LOADED, Whoo hoo!
6 years ago (2014-11-27 20:36:20 UTC) #73
commit-bot: I haz the power
Committed patchset #14 (id:300001)
6 years ago (2014-11-27 21:59:15 UTC) #74
commit-bot: I haz the power
Patchset 14 (id:??) landed as https://crrev.com/793ee5bff54aa3cb1c1873dfeeeb1f36c42e810f Cr-Commit-Position: refs/heads/master@{#306027}
6 years ago (2014-11-27 22:00:04 UTC) #75
Mark P
5 years, 10 months ago (2015-02-26 17:00:19 UTC) #77
Message was sent while issue was closed.
lgtm with one trivial comment

Thanks for tracking this down and fixing it.  Our users will appreciate it.

--mark

Powered by Google App Engine
This is Rietveld 408576698