Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/ui/cocoa/history_menu_bridge.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_HISTORY_MENU_BRIDGE_H_
 #define CHROME_BROWSER_UI_COCOA_HISTORY_MENU_BRIDGE_H_
 
 #import <Cocoa/Cocoa.h>
 #include <map>
 #include <vector>
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/ref_counted.h"
 #include "base/task/cancelable_task_tracker.h"
 #import "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service_observer.h"
 #import "chrome/browser/ui/cocoa/main_menu_item.h"
+#include "components/history/core/browser/history_service_observer.h"
 #include "components/sessions/session_id.h"
 #include "content/public/browser/notification_observer.h"
 
 class NotificationRegistrar;
 class PageUsageData;
 class Profile;
 class TabRestoreService;
 @class HistoryMenuCocoaController;
 
 namespace {
@@ skipping 21 matching lines @@
 // action mechanism.
 //
 // These menu items do not use firstResponder as their target. Rather, they are
 // hooked directly up to the HistoryMenuCocoaController that then bridges back
 // to this class. These items are created via the AddItemToMenu() helper. Also,
 // unlike the typical ownership model, this bridge owns its controller. The
 // controller is very thin and only exists to interact with Cocoa, but this
 // class does the bulk of the work.
 class HistoryMenuBridge : public content::NotificationObserver,
                           public TabRestoreServiceObserver,
-                          public MainMenuItem {
+                          public MainMenuItem,
+                          public history::HistoryServiceObserver {
  public:
   // This is a generalization of the data we store in the history menu because
   // we pull things from different sources with different data types.
   struct HistoryItem {
    public:
     HistoryItem();
     // Copy constructor allowed.
     HistoryItem(const HistoryItem& copy);
     ~HistoryItem();
 
@@ skipping 69 matching lines @@
 
   // Looks up an NSMenuItem in the |menu_item_map_| and returns the
   // corresponding HistoryItem.
   HistoryItem* HistoryItemForMenuItem(NSMenuItem* item);
 
   // I wish I has a "friend @class" construct. These are used by the HMCC
   // to access model information when responding to actions.
   HistoryService* service();
   Profile* profile();
 
+  // Is called when |service| is loaded.

[sdefresne, 2014/10/20 13:15:42]

// history::HistoryServiceObserver:

[nshaik, 2014/10/29 08:43:39]

Done.

+  virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;

[sdefresne, 2014/10/20 13:15:42]

OVERRIDE -> override

[nshaik, 2014/10/29 08:43:39]

Done.

+
  protected:
   // Return the History menu.
   virtual NSMenu* HistoryMenu();
 
   // Clear items in the given |menu|. Menu items in the same section are given
   // the same tag. This will go through the entire history menu, removing all
   // items with a given tag. Note that this will recurse to submenus, removing
   // child items from the menu item map. This will only remove items that have
   // a target hooked up to the |controller_|.
   void ClearMenuSection(NSMenu* menu, NSInteger tag);
@@ skipping 62 matching lines @@
   bool create_in_progress_;
   bool need_recreate_;
 
   // The default favicon if a HistoryItem does not have one.
   base::scoped_nsobject<NSImage> default_favicon_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryMenuBridge);
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_HISTORY_MENU_BRIDGE_H_