Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/test/base/ui_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_UI_TEST_UTILS_H_
 #define CHROME_TEST_BASE_UI_TEST_UTILS_H_
 
 #include <map>
 #include <queue>
 #include <set>
@@ skipping 288 matching lines @@
       const base::Closure& quit_task,
       history::QueryResults* results);
 
   std::vector<GURL> urls_;
 
   base::CancelableTaskTracker tracker_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryEnumerator);
 };
 
+// Wait for HistoryService to load.

[sdefresne, 2014/09/23 08:45:10]

You can move this class in ui_test_utils.cc since it is not used from any other
file.

[nshaik, 2014/10/29 08:43:39]

Done.

+class WaitHistoryLoadedObserver : public history::HistoryServiceObserver {
+ public:
+  explicit WaitHistoryLoadedObserver(content::MessageLoopRunner* runner);
+  // Is called when |service| is loaded.

[sdefresne, 2014/10/20 13:15:43]

// history::HistoryServiceObserver:

+  virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;

[sdefresne, 2014/10/20 13:15:43]

OVERRIDE -> override

+  virtual ~WaitHistoryLoadedObserver();

[sdefresne, 2014/10/20 13:15:43]

Move the destructor with the constructor.

+
+ private:
+  // weak
+  content::MessageLoopRunner* runner_;
+};
+
 }  // namespace ui_test_utils
 
 #endif  // CHROME_TEST_BASE_UI_TEST_UTILS_H_