components/history/core/browser/history_service_observer.h - Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service_observer.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_service_observer.h

diff --git a/components/history/core/browser/history_service_observer.h b/components/history/core/browser/history_service_observer.h

index ecee03cad827f0a15660753bafb44d7e11a3cec1..97903cf149ba4e429de01137727073ece090ef65 100644

--- a/components/history/core/browser/history_service_observer.h

+++ b/components/history/core/browser/history_service_observer.h

@@ -42,6 +42,12 @@ class HistoryServiceObserver {

virtual void OnAddVisit(HistoryService* history_service,

const BriefVisitInfo& info) {}

+ // Is called to notify when |history_service| has finished loading.

+ virtual void OnHistoryServiceLoaded(HistoryService* history_service) {}

+ // Is called to notify when |history_service| is being deleted.

+ virtual void HistoryServiceBeingDeleted(HistoryService* history_service) {}

private:

DISALLOW_COPY_AND_ASSIGN(HistoryServiceObserver);

};