Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/history/history_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The history system runs on a background thread so that potentially slow
 // database operations don't delay the browser. This backend processing is
 // represented by HistoryBackend. The HistoryService's job is to dispatch to
 // that thread.
 //
 // Main thread                       History thread
@@ skipping 1181 matching lines @@
   // backend has allocated for us. The receiver of the notification will cast
   // this to the proper type.
   content::Details<history::HistoryDetails> det(details.get());
 
   content::NotificationService::current()->Notify(type, source, det);
 }
 
 void HistoryService::OnDBLoaded() {
   DCHECK(thread_checker_.CalledOnValidThread());
   backend_loaded_ = true;
-  content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_HISTORY_LOADED,
-      content::Source<Profile>(profile_),
-      content::Details<HistoryService>(this));
+  NotifyHistoryServiceLoaded();
 }
 
 bool HistoryService::GetRowForURL(const GURL& url, history::URLRow* url_row) {
   DCHECK(thread_checker_.CalledOnValidThread());
   history::URLDatabase* db = InMemoryDatabase();
   return db && (db->GetRowForURL(url, url_row) != 0);
 }
 
 void HistoryService::AddVisitDatabaseObserver(
     history::VisitDatabaseObserver* observer) {
   DCHECK(thread_checker_.CalledOnValidThread());
   visit_database_observers_.AddObserver(observer);
 }
 
 void HistoryService::RemoveVisitDatabaseObserver(
     history::VisitDatabaseObserver* observer) {
   DCHECK(thread_checker_.CalledOnValidThread());
   visit_database_observers_.RemoveObserver(observer);
 }
 
 void HistoryService::NotifyVisitDBObserversOnAddVisit(
     const history::BriefVisitInfo& info) {
   DCHECK(thread_checker_.CalledOnValidThread());
   FOR_EACH_OBSERVER(history::VisitDatabaseObserver, visit_database_observers_,
                     OnAddVisit(info));
 }
+
+void HistoryService::AddHistoryServiceObserver(

[sdefresne, 2014/10/20 13:15:41]

Note: those two methods have been added already. I think you probably want to
rebase your code on top of origin/master and remove them.

[nshaik, 2014/10/29 08:43:39]

Done.

+    history::HistoryServiceObserver* observer) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  history_service_observers_.AddObserver(observer);
+}
+
+void HistoryService::RemoveHistoryServiceObserver(
+    history::HistoryServiceObserver* observer) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  history_service_observers_.RemoveObserver(observer);
+}
+
+void HistoryService::NotifyHistoryServiceLoaded() {
+  FOR_EACH_OBSERVER(history::HistoryServiceObserver,
+                    history_service_observers_,
+                    HistoryServiceLoaded(this));
+}