Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/history/in_memory_url_index.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_
 #define CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_
 
 #include <functional>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/history/history_db_task.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/history/in_memory_url_index_types.h"
 #include "chrome/browser/history/scored_history_match.h"
+#include "components/history/core/browser/history_service_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "sql/connection.h"
 
 class HistoryQuickProviderTest;
+class HistoryService;
 class Profile;
 
 namespace base {
 class Time;
 }
 
 namespace in_memory_url_index {
 class InMemoryURLIndexCacheItem;
 }
 
@@ skipping 21 matching lines @@
 // URL strings to lowercase. Multi-byte-edness makes no difference when
 // indexing or when searching the index as the final filtering of results
 // is dependent on the comparison of a string of bytes, not individual
 // characters. While the lookup of those bytes during a search in the
 // |char_word_map_| could serve up words in which the individual char16
 // occurs as a portion of a composite character the next filtering step
 // will eliminate such words except in the case where a single character
 // is being searched on and which character occurs as the second char16 of a
 // multi-char16 instance.
 class InMemoryURLIndex : public content::NotificationObserver,
-                         public base::SupportsWeakPtr<InMemoryURLIndex> {
+                         public base::SupportsWeakPtr<InMemoryURLIndex>,
+                         public history::HistoryServiceObserver {
  public:
   // Defines an abstract class which is notified upon completion of restoring
   // the index's private data either by reading from the cache file or by
   // rebuilding from the history database.
   class RestoreCacheObserver {
    public:
     virtual ~RestoreCacheObserver();
 
     // Callback that lets the observer know that the restore operation has
     // completed. |succeeded| indicates if the restore was successful. This is
@@ skipping 54 matching lines @@
   }
   void set_save_cache_observer(SaveCacheObserver* save_cache_observer) {
     save_cache_observer_ = save_cache_observer;
   }
 
   // Indicates that the index restoration is complete.
   bool restored() const {
     return restored_;
   }
 
+  // Is called when |service| is loaded.

[sdefresne, 2014/09/23 08:45:09]

When overriding methods from an interface, you don't copy descriptions for the
methods, but just put the name of the interface providing those methods (same
for the other places).

// history::HistoryServiceObserver:
virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;

[nshaik, 2014/10/29 08:43:39]

Done.

+  virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;

[sdefresne, 2014/10/20 13:15:42]

OVERRIDE -> override

+
  private:
   friend class ::HistoryQuickProviderTest;
   friend class InMemoryURLIndexTest;
   friend class InMemoryURLIndexCacheTest;
   FRIEND_TEST_ALL_PREFIXES(LimitedInMemoryURLIndexTest, Initialization);
 
   // Creating one of me without a history path is not allowed (tests excepted).
   InMemoryURLIndex();
 
   // HistoryDBTask used to rebuild our private data from the history database.
@@ skipping 142 matching lines @@
   // temporary safety check to insure that the cache is saved before the
   // index has been destructed.
   bool needs_to_be_cached_;
 
   DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_