chrome/browser/search_engines/chrome_template_url_service_client.h - Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/chrome_template_url_service_client.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search_engines/chrome_template_url_service_client.h

diff --git a/chrome/browser/search_engines/chrome_template_url_service_client.h b/chrome/browser/search_engines/chrome_template_url_service_client.h

index a62a1352f2a1438f393ca279a15803791d13a210..5afcddb2790d2319eb88b335eaf1ebfd046bde2f 100644

--- a/chrome/browser/search_engines/chrome_template_url_service_client.h

+++ b/chrome/browser/search_engines/chrome_template_url_service_client.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_

#define CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_

+#include "base/scoped_observer.h"

#include "components/history/core/browser/history_service_observer.h"

#include "components/search_engines/template_url_service_client.h"

@@ -37,6 +38,8 @@ class ChromeTemplateURLServiceClient : public TemplateURLServiceClient,

private:

TemplateURLService* owner_;

+ ScopedObserver<HistoryService, HistoryServiceObserver>

+ history_service_observer_;

HistoryService* history_service_;

DISALLOW_COPY_AND_ASSIGN(ChromeTemplateURLServiceClient);