chrome/browser/history/in_memory_history_backend.h - Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/in_memory_history_backend.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/in_memory_history_backend.h

diff --git a/chrome/browser/history/in_memory_history_backend.h b/chrome/browser/history/in_memory_history_backend.h

index d360995eab63b281324b068cb6e54061400629a1..f06c3f6f4220e0726f7015ecbdb782e58a3dda45 100644

--- a/chrome/browser/history/in_memory_history_backend.h

+++ b/chrome/browser/history/in_memory_history_backend.h

@@ -25,6 +25,7 @@

#include "base/basictypes.h"

#include "base/gtest_prod_util.h"

#include "base/memory/scoped_ptr.h"

+#include "base/scoped_observer.h"

#include "components/history/core/browser/history_service_observer.h"

#include "components/history/core/browser/keyword_id.h"

#include "content/public/browser/notification_observer.h"

@@ -109,6 +110,8 @@ class InMemoryHistoryBackend : public HistoryServiceObserver,

// The profile that this object is attached. May be NULL before

// initialization.

Profile* profile_;

+ ScopedObserver<HistoryService, HistoryServiceObserver>

+ history_service_observer_;

HistoryService* history_service_;

DISALLOW_COPY_AND_ASSIGN(InMemoryHistoryBackend);