Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/history/history_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 35 matching lines @@
 class PageUsageRequest;
 class Profile;
 struct ImportedFaviconUsage;
 class SkBitmap;
 
 namespace base {
 class FilePath;
 class Thread;
 }
 
+namespace safe_browsing {
+class LastDownloadFinder;
+}
+
 namespace visitedlink {
 class VisitedLinkMaster;
 }
 
 namespace history {
 
 class HistoryBackend;
 class HistoryClient;
 class HistoryDatabase;
 class HistoryDBTask;
@@ skipping 466 matching lines @@
   friend class FaviconService;
   friend class history::HistoryBackend;
   friend class history::HistoryQueryTest;
   friend class HistoryOperation;
   friend class HistoryQuickProviderTest;
   friend class history::HistoryTest;
   friend class HistoryURLProvider;
   friend class HistoryURLProviderTest;
   friend class history::InMemoryURLIndexTest;
   template<typename Info, typename Callback> friend class DownloadRequest;
+  friend class safe_browsing::LastDownloadFinder;
   friend class PageUsageRequest;
   friend class RedirectRequest;
+  friend class SyncBookmarkDataTypeControllerTest;
   friend class TestingProfile;
 
   // Called on shutdown, this will tell the history backend to complete and
   // will release pointers to it. No other functions should be called once
   // cleanup has happened that may dispatch to the history thread (because it
   // will be NULL).
   //
   // In practice, this will be called by the service manager (BrowserProcess)
   // when it is being destroyed. Because that reference is being destroyed, it
   // should be impossible for anybody else to call the service, even if it is
@@ skipping 42 matching lines @@
   // The |row| ID will be set to the value that is currently in effect in the
   // main history database. |redirects| is the list of redirects leading up to
   // the URL. If we have a redirect chain A -> B -> C and user is visiting C,
   // then |redirects[0]=B| and |redirects[1]=A|. If there are no redirects,
   // |redirects| is an empty vector.
   void NotifyURLVisited(ui::PageTransition transition,
                         const history::URLRow& row,
                         const history::RedirectList& redirects,
                         base::Time visit_time);
 
+  // Notify all HistoryServiceObservers registered that the
+  // HistoryService has finished loading.
+  void NotifyHistoryServiceLoaded();
+
   // Favicon -------------------------------------------------------------------
 
   // These favicon methods are exposed to the FaviconService. Instead of calling
   // these methods directly you should call the respective method on the
   // FaviconService.
 
   // Used by FaviconService to get the favicon bitmaps from the history backend
   // whose edge sizes most closely match |desired_sizes| for |icon_types|. If
   // |desired_sizes| has a '0' entry, the largest favicon bitmap for
   // |icon_types| is returned. The returned FaviconBitmapResults will have at
@@ skipping 218 matching lines @@
                          const ArgB& b,
                          const ArgC& c,
                          const ArgD& d,
                          const ArgE& e) {
     DCHECK(thread_) << "History service being called after cleanup";
     DCHECK(thread_checker_.CalledOnValidThread());
     ScheduleTask(priority, base::Bind(func, history_backend_.get(),
                                       a, b, c, d, e));
   }
 
+  // TODO(sdefresne): remove this method.

[sdefresne, 2014/11/04 14:12:29]

nit: add reference to http://crbug.com/430070 (I just created it, sorry).

[nshaik, 2014/11/04 21:20:27]

Done.

+  Profile* profile() { return profile_; }
+
   base::ThreadChecker thread_checker_;
 
   content::NotificationRegistrar registrar_;
 
   // The thread used by the history service to run complicated operations.
   // |thread_| is NULL once |Cleanup| is NULL.
   base::Thread* thread_;
 
   // This class has most of the implementation and runs on the 'thread_'.
   // You MUST communicate with this class ONLY through the thread_'s
@@ skipping 39 matching lines @@
 
   history::DeleteDirectiveHandler delete_directive_handler_;
 
   // All vended weak pointers are invalidated in Cleanup().
   base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryService);
 };
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_