Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 500343002: [turbofan] Add backend support for load/store float32 values. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add backend support for load/store float32 values. This is the bare minimum required to support typed arrays. Support for working with float32 values will be added based on this. TEST=compiler-unittests,cctest R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23386

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -43 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 1 chunk +11 lines, -2 lines 0 comments Download
M src/compiler/machine-type.h View 3 chunks +15 lines, -11 lines 0 comments Download
M src/compiler/machine-type.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +20 lines, -9 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/arm/instruction-selector-arm-unittest.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.h View 3 chunks +14 lines, -1 line 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/compiler-unittests/x64/instruction-selector-x64-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
bmeurer@chromium.org changed reviewers: + svenpanne@chromium.org
6 years, 4 months ago (2014-08-26 06:00:43 UTC) #1
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-26 06:00:43 UTC) #2
Sven Panne
lgtm
6 years, 4 months ago (2014-08-26 06:43:23 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-26 08:29:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698