Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478733002: Rename repaint to paintInvalidation for remaining methods. (Closed)

Created:
6 years, 4 months ago by dsinclair
Modified:
6 years, 4 months ago
CC:
aboxhall, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, cbiesinger, chromiumbugtracker_adobe.com, dmazzoni, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr., Manuel Rego, rune+blink, svillar, zoltan1
Project:
blink
Visibility:
Public.

Description

Rename repaint to paintInvalidation for remaining methods. This completes the remaining bulk renames for repaint to paintInvalidation. BUG=338691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180388

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -362 lines) Patch
M Source/core/accessibility/AXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 8 chunks +24 lines, -24 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 6 chunks +25 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 10 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 12 chunks +24 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 8 chunks +27 lines, -27 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 3 chunks +25 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderRegion.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSelectionInfo.h View 4 chunks +19 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderSliderContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderView.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 17 chunks +23 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/line/LineLayoutState.h View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
leviw_travelin_and_unemployed
This is a really really big patch. I don't see anything wrong with it, but ...
6 years, 4 months ago (2014-08-15 18:45:48 UTC) #1
leviw_travelin_and_unemployed
lgtm with the one change.
6 years, 4 months ago (2014-08-15 18:51:16 UTC) #2
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 4 months ago (2014-08-15 19:02:57 UTC) #3
dsinclair
https://codereview.chromium.org/478733002/diff/1/Source/core/rendering/RenderBlockFlow.h File Source/core/rendering/RenderBlockFlow.h (right): https://codereview.chromium.org/478733002/diff/1/Source/core/rendering/RenderBlockFlow.h#newcode488 Source/core/rendering/RenderBlockFlow.h:488: static void paintInvalidationForDirtyFloats(Vector<FloatWithRect>& floats); On 2014/08/15 18:45:48, leviw wrote: ...
6 years, 4 months ago (2014-08-15 19:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/478733002/20001
6 years, 4 months ago (2014-08-15 19:03:59 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:10:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180388

Powered by Google App Engine
This is Rietveld 408576698