Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 478733002: Rename repaint to paintInvalidation for remaining methods. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTableCol.cpp ('k') | Source/core/rendering/RenderTableSection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 cell->layout(); 177 cell->layout();
178 } 178 }
179 } 179 }
180 180
181 m_overflow.clear(); 181 m_overflow.clear();
182 addVisualEffectOverflow(); 182 addVisualEffectOverflow();
183 183
184 // We only ever need to issue paint invalidations if our cells didn't, which means that they didn't need 184 // We only ever need to issue paint invalidations if our cells didn't, which means that they didn't need
185 // layout, so we know that our bounds didn't change. This code is just makin g up for 185 // layout, so we know that our bounds didn't change. This code is just makin g up for
186 // the fact that we did not invalidate paints in setStyle() because we had a layout hint. 186 // the fact that we did not invalidate paints in setStyle() because we had a layout hint.
187 // We cannot call repaint() because our clippedOverflowRectForPaintInvalidat ion() is taken from the 187 // We cannot call paintInvalidationForWholeRenderer() because our clippedOve rflowRectForPaintInvalidation() is taken from the
188 // parent table, and being mid-layout, that is invalid. Instead, we issue pa int invalidations for our cells. 188 // parent table, and being mid-layout, that is invalid. Instead, we issue pa int invalidations for our cells.
189 if (selfNeedsLayout() && checkForPaintInvalidation()) { 189 if (selfNeedsLayout() && checkForPaintInvalidation()) {
190 for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell()) { 190 for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell()) {
191 // FIXME: Is this needed with Repaint After Layout? 191 // FIXME: Is this needed when issuing paint invalidations after layo ut?
192 cell->setShouldDoFullPaintInvalidation(true); 192 cell->setShouldDoFullPaintInvalidation(true);
193 } 193 }
194 } 194 }
195 195
196 // RenderTableSection::layoutRows will set our logical height and width late r, so it calls updateLayerTransform(). 196 // RenderTableSection::layoutRows will set our logical height and width late r, so it calls updateLayerTransform().
197 clearNeedsLayout(); 197 clearNeedsLayout();
198 } 198 }
199 199
200 // Hit Testing 200 // Hit Testing
201 bool RenderTableRow::nodeAtPoint(const HitTestRequest& request, HitTestResult& r esult, const HitTestLocation& locationInContainer, const LayoutPoint& accumulate dOffset, HitTestAction action) 201 bool RenderTableRow::nodeAtPoint(const HitTestRequest& request, HitTestResult& r esult, const HitTestLocation& locationInContainer, const LayoutPoint& accumulate dOffset, HitTestAction action)
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // Paint the row background behind the cell. 237 // Paint the row background behind the cell.
238 if (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == P aintPhaseChildBlockBackground) 238 if (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == P aintPhaseChildBlockBackground)
239 cell->paintBackgroundsBehindCell(paintInfo, paintOffset, this); 239 cell->paintBackgroundsBehindCell(paintInfo, paintOffset, this);
240 if (!cell->hasSelfPaintingLayer()) 240 if (!cell->hasSelfPaintingLayer())
241 cell->paint(paintInfo, paintOffset); 241 cell->paint(paintInfo, paintOffset);
242 } 242 }
243 } 243 }
244 244
245 void RenderTableRow::imageChanged(WrappedImagePtr, const IntRect*) 245 void RenderTableRow::imageChanged(WrappedImagePtr, const IntRect*)
246 { 246 {
247 // FIXME: Examine cells and repaint only the rect the image paints in. 247 // FIXME: Examine cells and issue paint invalidations of only the rect the i mage paints in.
248 paintInvalidationForWholeRenderer(); 248 paintInvalidationForWholeRenderer();
249 } 249 }
250 250
251 RenderTableRow* RenderTableRow::createAnonymous(Document* document) 251 RenderTableRow* RenderTableRow::createAnonymous(Document* document)
252 { 252 {
253 RenderTableRow* renderer = new RenderTableRow(0); 253 RenderTableRow* renderer = new RenderTableRow(0);
254 renderer->setDocumentForAnonymous(document); 254 renderer->setDocumentForAnonymous(document);
255 return renderer; 255 return renderer;
256 } 256 }
257 257
258 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 258 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
259 { 259 {
260 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 260 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
261 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 261 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
262 newRow->setStyle(newStyle.release()); 262 newRow->setStyle(newStyle.release());
263 return newRow; 263 return newRow;
264 } 264 }
265 265
266 } // namespace blink 266 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableCol.cpp ('k') | Source/core/rendering/RenderTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698