Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 469373002: Bindings generation emits (more) correct null checking (Closed)

Created:
6 years, 4 months ago by Leaf
Modified:
6 years, 4 months ago
Reviewers:
vsm, terry
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Bindings generation emits (more) correct null checking Re-apply "Throw exception on null pointers in raw toNative" Adding in null checking to our toNative functions (https://codereview.chromium.org/450053002/) exposed bugs in our binding generation. That patch was reverted, this CL reapplies the patch, and adds in fixes to the binding generation code so that we generate the correct toNative functions. Patch 1 is the original (reverted) patch from here: https://codereview.chromium.org/450053002/ Patch 2 adds in fixes to the bindings code so that we generate the correct toNative calls. BUG=http://dartbug.com/19948 R=vsm@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=180372

Patch Set 1 #

Patch Set 2 : Adding in fixes to binding generation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -75 lines) Patch
M Source/bindings/dart/DartUtilities.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartUtilities.cpp View 1 6 chunks +55 lines, -0 lines 0 comments Download
M Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/dart/custom/DartFormDataCustom.cpp View 2 chunks +1 line, -21 lines 0 comments Download
M Source/bindings/dart/custom/DartMessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/dart/custom/DartNodeCustom.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/dart/scripts/dart_attributes.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/bindings/dart/scripts/dart_interface.py View 1 7 chunks +8 lines, -7 lines 0 comments Download
M Source/bindings/dart/scripts/dart_methods.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/dart/scripts/dart_types.py View 1 5 chunks +43 lines, -22 lines 0 comments Download
M Source/bindings/dart/scripts/templates/interface_h.template View 1 chunk +22 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Leaf
6 years, 4 months ago (2014-08-14 16:45:45 UTC) #1
vsm
lgtm
6 years, 4 months ago (2014-08-15 10:28:25 UTC) #2
Leaf
6 years, 4 months ago (2014-08-15 16:17:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 180372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698