Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: Source/bindings/dart/custom/DartNodeCustom.cpp

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/custom/DartNodeCustom.cpp
diff --git a/Source/bindings/dart/custom/DartNodeCustom.cpp b/Source/bindings/dart/custom/DartNodeCustom.cpp
index bed16e61c65dfc7704faf2c5c282e6dfecfcc412..ba6b997f613e2d8fa1fa6023fb00b43412abc685 100644
--- a/Source/bindings/dart/custom/DartNodeCustom.cpp
+++ b/Source/bindings/dart/custom/DartNodeCustom.cpp
@@ -55,11 +55,11 @@ void insertBeforeCallback(Dart_NativeArguments args)
{
Node* receiver = DartDOMWrapper::receiver<Node>(args);
- Node* newChild = DartNode::toNative(args, 1, exception);
+ Node* newChild = DartNode::toNativeWithNullCheck(args, 1, exception);
if (exception)
goto fail;
- Node* refChild = DartNode::toNative(args, 2, exception);
+ Node* refChild = DartNode::toNativeWithNullCheck(args, 2, exception);
if (exception)
goto fail;
@@ -88,11 +88,11 @@ void replaceChildCallback(Dart_NativeArguments args)
{
Node* receiver = DartDOMWrapper::receiver<Node>(args);
- Node* newChild = DartNode::toNative(args, 1, exception);
+ Node* newChild = DartNode::toNativeWithNullCheck(args, 1, exception);
if (exception)
goto fail;
- Node* oldChild = DartNode::toNative(args, 2, exception);
+ Node* oldChild = DartNode::toNativeWithNullCheck(args, 2, exception);
if (exception)
goto fail;
@@ -121,7 +121,7 @@ void removeChildCallback(Dart_NativeArguments args)
{
Node* receiver = DartDOMWrapper::receiver<Node>(args);
- Node* child = DartNode::toNative(args, 1, exception);
+ Node* child = DartNode::toNativeWithNullCheck(args, 1, exception);
if (exception)
goto fail;
@@ -150,7 +150,7 @@ void appendChildCallback(Dart_NativeArguments args)
{
Node* receiver = DartDOMWrapper::receiver<Node>(args);
- Node* child = DartNode::toNative(args, 1, exception);
+ Node* child = DartNode::toNativeWithNullCheck(args, 1, exception);
if (exception)
goto fail;

Powered by Google App Engine
This is Rietveld 408576698