Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: Source/bindings/dart/custom/DartFormDataCustom.cpp

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/custom/DartFormDataCustom.cpp
diff --git a/Source/bindings/dart/custom/DartFormDataCustom.cpp b/Source/bindings/dart/custom/DartFormDataCustom.cpp
index 79646abec4e9edbf3306fd0f387f7af5b45930f7..3566608307d49ef9f74567f0b23cf78c42e56754 100644
--- a/Source/bindings/dart/custom/DartFormDataCustom.cpp
+++ b/Source/bindings/dart/custom/DartFormDataCustom.cpp
@@ -37,26 +37,6 @@ namespace WebCore {
namespace DartFormDataInternal {
-void constructorCallback(Dart_NativeArguments args)
-{
- Dart_Handle exception = 0;
- {
- HTMLFormElement* form = 0;
- if (!Dart_IsNull(Dart_GetNativeArgument(args, 0))) {
- form = DartHTMLFormElement::toNative(Dart_GetNativeArgument(args, 0), exception);
- if (exception)
- goto fail;
- }
-
- DartDOMWrapper::returnToDart<DartFormData>(args, DOMFormData::create(form));
- return;
- }
-
-fail:
- Dart_ThrowException(exception);
- ASSERT_NOT_REACHED();
-}
-
void appendCallback(Dart_NativeArguments args)
{
Dart_Handle exception = 0;
@@ -80,7 +60,7 @@ void appendCallback(Dart_NativeArguments args)
return;
}
- Blob* blob = DartBlob::toNative(arg2, exception);
+ Blob* blob = DartBlob::toNativeWithNullCheck(arg2, exception);
if (exception)
goto fail;

Powered by Google App Engine
This is Rietveld 408576698