Source/bindings/dart/scripts/dart_attributes.py - Issue 469373002: Bindings generation emits (more) correct null checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/scripts/dart_attributes.py

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/dart/scripts/dart_attributes.py

diff --git a/Source/bindings/dart/scripts/dart_attributes.py b/Source/bindings/dart/scripts/dart_attributes.py

index 6205396e6bd3fee891eb2a31fc0be96599d3e8fc..6e295ca0c83fca0ddf5379fa5b31438e6f7e02b7 100644

--- a/Source/bindings/dart/scripts/dart_attributes.py

+++ b/Source/bindings/dart/scripts/dart_attributes.py

@@ -305,6 +305,7 @@ def generate_setter(interface, attribute, contents):

(target_attribute_name, target_interface_name))

extended_attributes = attribute.extended_attributes

+ interface_extended_attributes = interface.extended_attributes

if 'PutForwards' in extended_attributes:

# Use target attribute in place of original attribute

@@ -327,7 +328,7 @@ def generate_setter(interface, attribute, contents):

'cpp_setter': setter_expression(interface, attribute, contents),

'dart_value_to_local_cpp_value':

attribute.idl_type.dart_value_to_local_cpp_value(

- extended_attributes, attribute.name, False, 1,

+ interface_extended_attributes, extended_attributes, attribute.name, False, 1,

contents['is_auto_scope']),

})