Bindings generation emits (more) correct null checking

Source/bindings/dart/scripts/dart_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 819 matching lines @@
         'idl_type_object': argument.idl_type,
         'preprocessed_type': argument.idl_type.preprocessed_type,
     }
 
 
 # [Constructor]
 def generate_constructor(interface, constructor):
     return {
         'argument_list': constructor_argument_list(interface, constructor),
         # TODO(terry): Use dart_methods.generate_argument instead constructor_argument.
-        'arguments': [constructor_argument(argument, index)
+        'arguments': [constructor_argument(interface, argument, index)
                       for index, argument in enumerate(constructor.arguments)],
         'has_exception_state':
             # [RaisesException=Constructor]
             interface.extended_attributes.get('RaisesException') == 'Constructor' or
             any(argument for argument in constructor.arguments
                 if argument.idl_type.name == 'SerializedScriptValue' or
                    argument.idl_type.is_integer_type),
         'is_constructor': True,
         'auto_scope': 'true',
         'is_auto_scope': True,
@@ skipping 27 matching lines @@
 
     # [RaisesException=Constructor]
     if interface.extended_attributes.get('RaisesException') == 'Constructor':
         arguments.append('es')
 
     return arguments
 
 
 # TODO(terry): Eliminate this function use dart_methods.generate_argument instead
 #              for all constructor arguments.
-def constructor_argument(argument, index):
+def constructor_argument(interface, argument, index):
     idl_type = argument.idl_type
     default_value = str(argument.default_value) if argument.default_value else None
 
     argument_content = {
         'cpp_type': idl_type.cpp_type_args(),
         'local_cpp_type': idl_type.cpp_type_args(argument.extended_attributes, used_as_argument=True),
         # FIXME: check that the default value's type is compatible with the argument's
         'default_value': default_value,
         # FIXME: remove once [Default] removed and just use argument.default_value
         'has_default': 'Default' in argument.extended_attributes or default_value,
         'idl_type_object': idl_type,
         'preprocessed_type': idl_type.preprocessed_type,
         # Dictionary is special-cased, but arrays and sequences shouldn't be
         'idl_type': not idl_type.array_or_sequence_type and idl_type.base_type,
         'index': index,
         'is_array_or_sequence_type': not not idl_type.array_or_sequence_type,
         'is_optional': argument.is_optional,
         'is_strict_type_checking': False,  # Required for overload resolution
         'name': argument.name,
-        'dart_value_to_local_cpp_value': dart_methods.dart_value_to_local_cpp_value(argument, index),
+        'dart_value_to_local_cpp_value': dart_methods.dart_value_to_local_cpp_value(interface, argument, index),
     }
     return argument_content
 
 
 def generate_constructor_overloads(constructors):
     if len(constructors) <= 1:
         return
     for overload_index, constructor in enumerate(constructors):
         constructor.update({
             'overload_index': overload_index + 1,
@@ skipping 80 matching lines @@
         'is_null_expression': is_null_expression(idl_type),
         'is_raises_exception': is_raises_exception,
         'name': DartUtilities.cpp_name(getter),
         'union_arguments': union_arguments,
         'dart_set_return_value': idl_type.dart_set_return_value('result',
                                                                 extended_attributes=extended_attributes,
                                                                 script_wrappable='receiver',
                                                                 release=idl_type.release)}
 
 
-def property_setter(setter):
+def property_setter(interface, setter):
     idl_type = setter.arguments[1].idl_type
     extended_attributes = setter.extended_attributes
+    interface_extended_attributes = interface.extended_attributes
     is_raises_exception = 'RaisesException' in extended_attributes
     return {
         'has_strict_type_checking':
             'StrictTypeChecking' in extended_attributes and
             idl_type.is_wrapper_type,
         'idl_type': idl_type.base_type,
         'is_custom': 'Custom' in extended_attributes,
         'has_exception_state': is_raises_exception or
                                idl_type.is_integer_type,
         'is_raises_exception': is_raises_exception,
         'name': DartUtilities.cpp_name(setter),
         'dart_value_to_local_cpp_value': idl_type.dart_value_to_local_cpp_value(
-            extended_attributes, 'propertyValue', False),
+            interface_extended_attributes, extended_attributes, 'propertyValue', False),
     }
 
 
 def property_deleter(deleter):
     idl_type = deleter.idl_type
     if str(idl_type) != 'boolean':
         raise Exception(
             'Only deleters with boolean type are allowed, but type is "%s"' %
             idl_type)
     extended_attributes = deleter.extended_attributes
@@ skipping 33 matching lines @@
         # setter RETURN_TYPE [OPTIONAL_IDENTIFIER](unsigned long ARG1, ARG_TYPE ARG2)
         setter = next(
             method
             for method in interface.operations
             if ('setter' in method.specials and
                 len(method.arguments) == 2 and
                 str(method.arguments[0].idl_type) == 'unsigned long'))
     except StopIteration:
         return None
 
-    return property_setter(setter)
+    return property_setter(interface, setter)
 
 
 def indexed_property_deleter(interface):
     try:
         # Find indexed property deleter, if present; has form:
         # deleter TYPE [OPTIONAL_IDENTIFIER](unsigned long ARG)
         deleter = next(
             method
             for method in interface.operations
             if ('deleter' in method.specials and
@@ skipping 33 matching lines @@
         # setter RETURN_TYPE [OPTIONAL_IDENTIFIER](DOMString ARG1, ARG_TYPE ARG2)
         setter = next(
             method
             for method in interface.operations
             if ('setter' in method.specials and
                 len(method.arguments) == 2 and
                 str(method.arguments[0].idl_type) == 'DOMString'))
     except StopIteration:
         return None
 
-    return property_setter(setter)
+    return property_setter(interface, setter)
 
 
 def named_property_deleter(interface):
     try:
         # Find named property deleter, if present; has form:
         # deleter TYPE [OPTIONAL_IDENTIFIER](DOMString ARG)
         deleter = next(
             method
             for method in interface.operations
             if ('deleter' in method.specials and
                 len(method.arguments) == 1 and
                 str(method.arguments[0].idl_type) == 'DOMString'))
     except StopIteration:
         return None
 
     return property_deleter(deleter)