Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp - Issue 469373002: Bindings generation emits (more) correct null checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp

diff --git a/Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp b/Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp

index adddb590ab0ce96537a22d0b3b6d59363bd19580..8d823a858233f954bece9bb49d4a5709c4ac6384 100644

--- a/Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp

+++ b/Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp

@@ -59,10 +59,10 @@ static PassRefPtr<CanvasStyle> toCanvasStyle(Dart_Handle value)

{

Dart_Handle exception = 0;

if (DartDOMWrapper::subtypeOf(value, DartCanvasGradient::dartClassId))

- return CanvasStyle::createFromGradient(DartCanvasGradient::toNative(value, exception));

+ return CanvasStyle::createFromGradient(DartCanvasGradient::toNativeWithNullCheck(value, exception));

if (DartDOMWrapper::subtypeOf(value, DartCanvasPattern::dartClassId))

- return CanvasStyle::createFromPattern(DartCanvasPattern::toNative(value, exception));

+ return CanvasStyle::createFromPattern(DartCanvasPattern::toNativeWithNullCheck(value, exception));

return nullptr;

}