Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: Source/bindings/dart/DartUtilities.cpp

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartUtilities.cpp
diff --git a/Source/bindings/dart/DartUtilities.cpp b/Source/bindings/dart/DartUtilities.cpp
index 25a3b2e7c28680a5fd7475307edcdea1a7352d15..921478ca03eb422d8da8173d23ffd60e289c7a5c 100644
--- a/Source/bindings/dart/DartUtilities.cpp
+++ b/Source/bindings/dart/DartUtilities.cpp
@@ -765,6 +765,11 @@ PassRefPtr<WTF::ArrayBufferView> DartUtilities::dartToExternalizedArrayBufferVie
return dartToArrayBufferViewHelper(array, exception, true);
}
+PassRefPtr<WTF::Int8Array> DartUtilities::dartToInt8ArrayWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
+{
+ return Dart_IsNull(handle) ? nullptr : dartToInt8Array(handle, exception);
+}
+
PassRefPtr<WTF::Int8Array> DartUtilities::dartToInt8Array(Dart_Handle handle, Dart_Handle& exception)
{
RefPtr<ArrayBufferView> view = DartUtilities::dartToArrayBufferView(handle, exception);
@@ -776,12 +781,23 @@ PassRefPtr<WTF::Int8Array> DartUtilities::dartToInt8Array(Dart_Handle handle, Da
return nullptr;
}
+PassRefPtr<WTF::Int8Array> DartUtilities::dartToInt8ArrayWithNullCheck(Dart_NativeArguments args, int idx, Dart_Handle& exception)
+{
+ Dart_Handle object = Dart_GetNativeArgument(args, idx);
+ return dartToInt8ArrayWithNullCheck(object, exception);
+}
+
PassRefPtr<WTF::Int8Array> DartUtilities::dartToInt8Array(Dart_NativeArguments args, int idx, Dart_Handle& exception)
{
Dart_Handle object = Dart_GetNativeArgument(args, idx);
return dartToInt8Array(object, exception);
}
+PassRefPtr<WTF::Int32Array> DartUtilities::dartToInt32ArrayWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
+{
+ return Dart_IsNull(handle) ? nullptr : dartToInt32Array(handle, exception);
+}
+
PassRefPtr<WTF::Int32Array> DartUtilities::dartToInt32Array(Dart_Handle handle, Dart_Handle& exception)
{
RefPtr<ArrayBufferView> view = DartUtilities::dartToArrayBufferView(handle, exception);
@@ -793,12 +809,23 @@ PassRefPtr<WTF::Int32Array> DartUtilities::dartToInt32Array(Dart_Handle handle,
return nullptr;
}
+PassRefPtr<WTF::Int32Array> DartUtilities::dartToInt32ArrayWithNullCheck(Dart_NativeArguments args, int idx, Dart_Handle& exception)
+{
+ Dart_Handle object = Dart_GetNativeArgument(args, idx);
+ return dartToInt32ArrayWithNullCheck(object, exception);
+}
+
PassRefPtr<WTF::Int32Array> DartUtilities::dartToInt32Array(Dart_NativeArguments args, int idx, Dart_Handle& exception)
{
Dart_Handle object = Dart_GetNativeArgument(args, idx);
return dartToInt32Array(object, exception);
}
+PassRefPtr<WTF::Uint8ClampedArray> DartUtilities::dartToUint8ClampedArrayWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
+{
+ return Dart_IsNull(handle) ? nullptr : dartToUint8ClampedArray(handle, exception);
+}
+
PassRefPtr<WTF::Uint8ClampedArray> DartUtilities::dartToUint8ClampedArray(Dart_Handle handle, Dart_Handle& exception)
{
RefPtr<ArrayBufferView> view = DartUtilities::dartToArrayBufferView(handle, exception);
@@ -810,12 +837,23 @@ PassRefPtr<WTF::Uint8ClampedArray> DartUtilities::dartToUint8ClampedArray(Dart_H
return nullptr;
}
+PassRefPtr<WTF::Uint8ClampedArray> DartUtilities::dartToUint8ClampedArrayWithNullCheck(Dart_NativeArguments args, int idx, Dart_Handle& exception)
+{
+ Dart_Handle object = Dart_GetNativeArgument(args, idx);
+ return dartToUint8ClampedArrayWithNullCheck(object, exception);
+}
+
PassRefPtr<WTF::Uint8ClampedArray> DartUtilities::dartToUint8ClampedArray(Dart_NativeArguments args, int idx, Dart_Handle& exception)
{
Dart_Handle object = Dart_GetNativeArgument(args, idx);
return dartToUint8ClampedArray(object, exception);
}
+PassRefPtr<WTF::Uint8Array> DartUtilities::dartToUint8ArrayWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
+{
+ return Dart_IsNull(handle) ? nullptr : dartToUint8Array(handle, exception);
+}
+
PassRefPtr<WTF::Uint8Array> DartUtilities::dartToUint8Array(Dart_Handle handle, Dart_Handle& exception)
{
RefPtr<ArrayBufferView> view = DartUtilities::dartToArrayBufferView(handle, exception);
@@ -827,12 +865,23 @@ PassRefPtr<WTF::Uint8Array> DartUtilities::dartToUint8Array(Dart_Handle handle,
return nullptr;
}
+PassRefPtr<WTF::Uint8Array> DartUtilities::dartToUint8ArrayWithNullCheck(Dart_NativeArguments args, int idx, Dart_Handle& exception)
+{
+ Dart_Handle object = Dart_GetNativeArgument(args, idx);
+ return dartToUint8ArrayWithNullCheck(object, exception);
+}
+
PassRefPtr<WTF::Uint8Array> DartUtilities::dartToUint8Array(Dart_NativeArguments args, int idx, Dart_Handle& exception)
{
Dart_Handle object = Dart_GetNativeArgument(args, idx);
return dartToUint8Array(object, exception);
}
+PassRefPtr<WTF::Float32Array> DartUtilities::dartToFloat32ArrayWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
+{
+ return Dart_IsNull(handle) ? nullptr : dartToFloat32Array(handle, exception);
+}
+
PassRefPtr<WTF::Float32Array> DartUtilities::dartToFloat32Array(Dart_Handle handle, Dart_Handle& exception)
{
RefPtr<ArrayBufferView> view = DartUtilities::dartToArrayBufferView(handle, exception);
@@ -844,6 +893,12 @@ PassRefPtr<WTF::Float32Array> DartUtilities::dartToFloat32Array(Dart_Handle hand
return nullptr;
}
+PassRefPtr<WTF::Float32Array> DartUtilities::dartToFloat32ArrayWithNullCheck(Dart_NativeArguments args, int idx, Dart_Handle& exception)
+{
+ Dart_Handle object = Dart_GetNativeArgument(args, idx);
+ return dartToFloat32ArrayWithNullCheck(object, exception);
+}
+
PassRefPtr<WTF::Float32Array> DartUtilities::dartToFloat32Array(Dart_NativeArguments args, int idx, Dart_Handle& exception)
{
Dart_Handle object = Dart_GetNativeArgument(args, idx);
« no previous file with comments | « Source/bindings/dart/DartUtilities.h ('k') | Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698