Source/bindings/dart/custom/DartMessageEventCustom.cpp - Issue 469373002: Bindings generation emits (more) correct null checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/custom/DartMessageEventCustom.cpp

Issue 469373002: Bindings generation emits (more) correct null checking (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Adding in fixes to binding generation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/dart/custom/DartMessageEventCustom.cpp

diff --git a/Source/bindings/dart/custom/DartMessageEventCustom.cpp b/Source/bindings/dart/custom/DartMessageEventCustom.cpp

index 77afcb35e866146c6707bbc58880755bb23e4397..316a49a661b7e851eceb471a7bf3a46cd7a585c7 100644

--- a/Source/bindings/dart/custom/DartMessageEventCustom.cpp

+++ b/Source/bindings/dart/custom/DartMessageEventCustom.cpp

@@ -123,7 +123,7 @@ void initMessageEventCallback(Dart_NativeArguments args)

if (exception)

goto fail;

- LocalDOMWindow* sourceArg = DartWindow::toNative(Dart_GetNativeArgument(args, 7), exception);

+ LocalDOMWindow* sourceArg = DartWindow::toNativeWithNullCheck(Dart_GetNativeArgument(args, 7), exception);

if (exception)

goto fail;