Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
rwlbuis
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, aboxhall, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, dmazzoni, gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, paulirish+reviews_chromium.org, f(malita), groby+blinkspell_chromium.org, sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Use ContainerNode::hasChildren() instead of firstChild() in conditionals Use ContainerNode::hasChildren() instead of firstChild() in conditionals to increase code readability a bit. R=rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179061

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeTraversal.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 6 chunks +6 lines, -8 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 4 months ago (2014-07-28 21:18:03 UTC) #1
rwlbuis
lgtm, good idea, old way was a bit hacky.
6 years, 4 months ago (2014-07-28 21:56:11 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 22:16:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/428533006/20001
6 years, 4 months ago (2014-07-28 22:17:59 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 22:42:30 UTC) #5
Message was sent while issue was closed. 
Change committed as 179061

Powered by Google App Engine
This is Rietveld 408576698