Source/core/inspector/DOMPatchSupport.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/DOMPatchSupport.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/DOMPatchSupport.cpp

diff --git a/Source/core/inspector/DOMPatchSupport.cpp b/Source/core/inspector/DOMPatchSupport.cpp

index a8ade6f8639b708b2838c1f60b0d8f94299a1738..f68df028b7bf97be20ff36cfb6e55e4b2c7f90ba 100644

--- a/Source/core/inspector/DOMPatchSupport.cpp

+++ b/Source/core/inspector/DOMPatchSupport.cpp

@@ -146,9 +146,9 @@ Node* DOMPatchSupport::patchNode(Node* node, const String& markup, ExceptionStat

for (Node* child = parentNode->firstChild(); child != node; child = child->nextSibling())

newList.append(createDigest(child, 0));

for (Node* child = fragment->firstChild(); child; child = child->nextSibling()) {

- if (isHTMLHeadElement(*child) && !child->firstChild() && markupCopy.find("</head>") == kNotFound)

+ if (isHTMLHeadElement(*child) && !child->hasChildren() && markupCopy.find("</head>") == kNotFound)

continue; // HTML5 parser inserts empty <head> tag whenever it parses <body>

- if (isHTMLBodyElement(*child) && !child->firstChild() && markupCopy.find("</body>") == kNotFound)

+ if (isHTMLBodyElement(*child) && !child->hasChildren() && markupCopy.find("</body>") == kNotFound)

continue; // HTML5 parser inserts empty <body> tag whenever it parses </head>

newList.append(createDigest(child, &m_unusedNodesMap));

}

« no previous file with comments | « Source/core/html/shadow/DateTimeEditElement.cpp ('k') | Source/core/svg/SVGTitleElement.cpp » ('j') | no next file with comments »