Source/core/svg/SVGTitleElement.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTitleElement.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTitleElement.cpp

diff --git a/Source/core/svg/SVGTitleElement.cpp b/Source/core/svg/SVGTitleElement.cpp

index 1f45f85401080613b79120ba48e5afdf71d3b108..bb52dbf03ed8e8224460ce7e72dba08c1ce721c8 100644

--- a/Source/core/svg/SVGTitleElement.cpp

+++ b/Source/core/svg/SVGTitleElement.cpp

@@ -39,7 +39,7 @@ Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode*

SVGElement::insertedInto(rootParent);

if (!rootParent->inDocument())

return InsertionDone;

- if (firstChild() && document().isSVGDocument())

+ if (hasChildren() && document().isSVGDocument())

document().setTitleElement(this);

return InsertionDone;

}

« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | no next file » | no next file with comments »